From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D9FC10F11 for ; Wed, 24 Apr 2019 17:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B92FC20811 for ; Wed, 24 Apr 2019 17:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556127092; bh=I9HwzjyGsE046FN12eL1NHu1z2i+9Cxh31PFHcPtGTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HGEACfpZSIjBN2hxv2W5YVMn2Un6GKdu5NInIkLV80NM8NYJ5pfnfnMFeyFcdPiFx rZUW5JQuT1ndT1gv2dznsSdBZt1n/E7yHS3wRZm2qzuY17ZQ5wb/T1m5glENKYF4YM svO2jzWMRgHrJR521r2GLBXC+5YZt3V7aQmBv6k0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403827AbfDXRbb (ORCPT ); Wed, 24 Apr 2019 13:31:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:57992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403800AbfDXRb3 (ORCPT ); Wed, 24 Apr 2019 13:31:29 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2826B2054F; Wed, 24 Apr 2019 17:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556127088; bh=I9HwzjyGsE046FN12eL1NHu1z2i+9Cxh31PFHcPtGTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H+4yOzEnOGU/a/thq8a10Rs8pXzZHvJk+LYzpnd+wBLSQGlIatdUDKhjFidGjvdmm lepJSoEqNLS38wFb6frz4RiRQ6j4S3Sgg9/MbKj4A2F25RJPnrPwHOf9mFhS5toCNa GnpB5bSQVrCMIU6zpcs3DGM5T9KXp3BKMkpfluEM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaesoo Lee , Hannes Reinecke , Bart Van Assche , "Martin K. Petersen" Subject: [PATCH 4.19 58/96] scsi: core: set result when the command cannot be dispatched Date: Wed, 24 Apr 2019 19:10:03 +0200 Message-Id: <20190424170923.663054867@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170919.829037226@linuxfoundation.org> References: <20190424170919.829037226@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaesoo Lee commit be549d49115422f846b6d96ee8fd7173a5f7ceb0 upstream. When SCSI blk-mq is enabled, there is a bug in handling errors in scsi_queue_rq. Specifically, the bug is not setting result field of scsi_request correctly when the dispatch of the command has been failed. Since the upper layer code including the sg_io ioctl expects to receive any error status from result field of scsi_request, the error is silently ignored and this could cause data corruptions for some applications. Fixes: d285203cf647 ("scsi: add support for a blk-mq based I/O path.") Cc: Signed-off-by: Jaesoo Lee Reviewed-by: Hannes Reinecke Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/scsi_lib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2149,8 +2149,12 @@ out_put_budget: ret = BLK_STS_DEV_RESOURCE; break; default: + if (unlikely(!scsi_device_online(sdev))) + scsi_req(req)->result = DID_NO_CONNECT << 16; + else + scsi_req(req)->result = DID_ERROR << 16; /* - * Make sure to release all allocated ressources when + * Make sure to release all allocated resources when * we hit an error, as we will never see this command * again. */