From: Christoph Hellwig <hch@lst.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jiri Slaby <jslaby@suse.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org,
"kernel-janitors@vger.kernel.org H Hartley Sweeten"
<hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: remove an unnecessary NULL check
Date: Thu, 25 Apr 2019 16:32:35 +0200 [thread overview]
Message-ID: <20190425143235.GD16790@lst.de> (raw)
In-Reply-To: <ab71b3ad-c737-82ed-5727-9f4382569b4b@mev.co.uk>
On Thu, Apr 25, 2019 at 03:31:01PM +0100, Ian Abbott wrote:
> On 25/04/2019 15:18, Christoph Hellwig wrote:
>> On Thu, Apr 25, 2019 at 03:13:49PM +0100, Ian Abbott wrote:
>>> So for comedi_isadma, we can just replace the NULL with a pointer to a
>>> static dummy device with a 24-bit coherent mask?
>>
>> It should be converted to a proper isa_driver, so that it gets a real
>> struct device.
>
> But it will work as a short term solution? comedi_isadma isn't a driver,
> but is used by a few comedi drivers for ISA cards.
Then convert the drivers properly and pass on the device from them.
prev parent reply other threads:[~2019-04-25 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 14:24 [PATCH] dma-mapping: remove an unnecessary NULL check Dan Carpenter
2019-04-24 14:27 ` Christoph Hellwig
2019-04-25 14:13 ` Ian Abbott
2019-04-25 14:18 ` Christoph Hellwig
2019-04-25 14:31 ` Ian Abbott
2019-04-25 14:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425143235.GD16790@lst.de \
--to=hch@lst.de \
--cc=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox