Re: [PATCH V3 3/3] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping

Peter Zijlstra
2019-04-24T16:47:18Z

On Tue, Apr 16, 2019 at 03:38:41PM -0400, Thara Gopinath wrote:
> Enable cpufreq cooling device to update the thermal pressure in
> event of a capped maximum frequency or removal of capped maximum
> frequency.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> drivers/thermal/cpu_cooling.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 6fff161..d5cc3c3 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -31,6 +31,7 @@
> #include <linux/slab.h>
> #include <linux/cpu.h>
> #include <linux/cpu_cooling.h>
> +#include <linux/sched/thermal.h>
>
> #include <trace/events/thermal.h>
>
> @@ -177,6 +178,9 @@ static int cpufreq_thermal_notifier(struct notifier_block *nb,
>
> if (policy->max > clipped_freq)
> cpufreq_verify_within_limits(policy, 0, clipped_freq);
> +
> + sched_update_thermal_pressure(policy->cpus,
> + policy->max, policy->cpuinfo.max_freq);

If it's already telling the cpufreq thing, why not get it from sugov
instead?