From: Greg KH <gregkh@linuxfoundation.org>
To: richard.gong@linux.intel.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@kernel.org,
atull@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1 4/6] firmware: add Intel Stratix10 remote system update driver
Date: Thu, 25 Apr 2019 22:30:46 +0200 [thread overview]
Message-ID: <20190425203046.GE22307@kroah.com> (raw)
In-Reply-To: <1554835562-25056-5-git-send-email-richard.gong@linux.intel.com>
On Tue, Apr 09, 2019 at 01:46:00PM -0500, richard.gong@linux.intel.com wrote:
> +/*
> + * This driver exposes some optional features of the Intel Stratix 10 SoC FPGA.
> + * The SysFS interfaces exposed here are FPGA Remote System Update (RSU)
It has never been "SysFS", it has always been "sysfs".
> + * related. They allow user space software to query the configuration system
> + * status and to request optional reboot behavior specific to Intel FPGAs.
> + */
> +
> +static ssize_t current_image_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct stratix10_rsu_priv *priv = dev_get_drvdata(dev);
> +
> + if (!priv)
> + return -ENODEV;
> +
> + return scnprintf(buf, PAGE_SIZE, "%ld", priv->status.current_image);
While it is all nice and fine to try to be "safe" and use scnprintf() it
turns out that if you EVER care about the size of a sysfs buffer, your
code is doing something wrong. This can just be a simple sprintf()
call.
Same goes for everywhere in this file.
thanks,
greg k-h
next prev parent reply other threads:[~2019-04-25 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:45 [PATCHv1 0/6] add Intel Stratix10 remote system update driver richard.gong
2019-04-09 18:45 ` [PATCHv1 1/6] firmware: stratix10-svc: add to support RSU notify richard.gong
2019-04-09 18:45 ` [PATCHv1 2/6] dt-bindings, firmware: add Intel Stratix10 remote system update binding richard.gong
2019-04-29 17:48 ` Rob Herring
2019-04-09 18:45 ` [PATCHv1 3/6] arm64: dts: stratix10: add remote system update richard.gong
2019-04-09 18:46 ` [PATCHv1 4/6] firmware: add Intel Stratix10 remote system update driver richard.gong
2019-04-25 20:30 ` Greg KH [this message]
2019-04-25 20:33 ` Greg KH
2019-04-09 18:46 ` [PATCHv1 5/6] firmware: rsu: document sysfs interface richard.gong
2019-04-25 20:27 ` Greg KH
2019-04-25 20:28 ` Greg KH
2019-04-09 18:46 ` [PATCHv1 6/6] MAINTAINERS: add maintainer for Intel Stratix10 FW drivers richard.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425203046.GE22307@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox