From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA92BC43219 for ; Thu, 25 Apr 2019 20:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA416206BF for ; Thu, 25 Apr 2019 20:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556224426; bh=B+HtDkKtr+dt1BgyjoGe661Ei7NQJQ25puSvPygs1G4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Jy5eOw6m4KQEDPllovbDntTKWrMQmeHijn0TTRebfi4cvqdCCv/2IEfFgXxxcGnrg Kd5sv1nqs+R//Jom/TqeHYPIIwXqhN0eXgS+YIPX4N/8breWA7nEzSvXwcIVyt4xNB YR0u7AU8K6bxL8/AQL9jATYhtgaH3NIc21m6WN4Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387701AbfDYUdp (ORCPT ); Thu, 25 Apr 2019 16:33:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:54178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbfDYUdp (ORCPT ); Thu, 25 Apr 2019 16:33:45 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3C67206A3; Thu, 25 Apr 2019 20:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556224424; bh=B+HtDkKtr+dt1BgyjoGe661Ei7NQJQ25puSvPygs1G4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pp/W/vnP91J7Fl5ayKe70ryx5hBcSZSlxRPwr3IEWpixWEXveP8kJmYVUVHrk7Rr3 W2qvhF4xFzsCWWQ46TX8qqRHrxWqW9ky6Cwf1tIpTHr02wYmHH6HP7D8T9wi6fR8kD gqwtTp1evgrAReCPFp79BXLRRDJJVZSL6PKEUDpU= Date: Thu, 25 Apr 2019 22:33:41 +0200 From: Greg KH To: richard.gong@linux.intel.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@kernel.org, atull@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Richard Gong Subject: Re: [PATCHv1 4/6] firmware: add Intel Stratix10 remote system update driver Message-ID: <20190425203341.GF22307@kroah.com> References: <1554835562-25056-1-git-send-email-richard.gong@linux.intel.com> <1554835562-25056-5-git-send-email-richard.gong@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554835562-25056-5-git-send-email-richard.gong@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 09, 2019 at 01:46:00PM -0500, richard.gong@linux.intel.com wrote: > +static ssize_t reboot_image_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct stratix10_rsu_priv *priv = dev_get_drvdata(dev); > + unsigned long address; > + int ret; > + > + if (priv == 0) > + return -ENODEV; > + > + ret = kstrtoul(buf, 0, &address); > + if (ret) > + return ret; > + > + rsu_send_msg(priv, COMMAND_RSU_UPDATE, > + address, rsu_update_callback); > + > + return count; > +} No error checking that the value was a sane one? That this message actually worked? I can write any random number in here and have no error happen at all? Nice! :( > +static ssize_t notify_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct stratix10_rsu_priv *priv = dev_get_drvdata(dev); > + unsigned long status; > + int ret; > + > + if (priv == 0) > + return -ENODEV; > + > + ret = kstrtoul(buf, 0, &status); > + if (ret) > + return ret; > + > + rsu_send_msg(priv, COMMAND_RSU_NOTIFY, > + status, rsu_notify_callback); > + > + return count; > +} Same comment here. > + > +static DEVICE_ATTR_RO(current_image); > +static DEVICE_ATTR_RO(fail_image); > +static DEVICE_ATTR_RO(state); > +static DEVICE_ATTR_RO(version); > +static DEVICE_ATTR_RO(error_location); > +static DEVICE_ATTR_RO(error_details); > +static DEVICE_ATTR_WO(reboot_image); > +static DEVICE_ATTR_WO(notify); > + > +static struct attribute *attrs[] = { > + &dev_attr_current_image.attr, > + &dev_attr_fail_image.attr, > + &dev_attr_state.attr, > + &dev_attr_version.attr, > + &dev_attr_error_location.attr, > + &dev_attr_error_details.attr, > + &dev_attr_reboot_image.attr, > + &dev_attr_notify.attr, > + NULL > +}; > + > +static struct attribute_group attr_group = { > + .attrs = attrs > +}; ATTRIBUTE_GROUP()? > +static int stratix10_rsu_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct stratix10_rsu_priv *priv; > + int ret; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->client.dev = dev; > + priv->client.receive_cb = NULL; > + priv->client.priv = priv; > + priv->status.current_image = 0; > + priv->status.fail_image = 0; > + priv->status.error_location = 0; > + priv->status.error_details = 0; > + priv->status.version = 0; > + priv->status.state = 0; > + > + mutex_init(&priv->lock); > + priv->chan = stratix10_svc_request_channel_byname(&priv->client, > + SVC_CLIENT_RSU); > + if (IS_ERR(priv->chan)) { > + dev_err(dev, "couldn't get service channel (%s)\n", > + SVC_CLIENT_RSU); > + return PTR_ERR(priv->chan); > + } > + > + init_completion(&priv->completion); > + platform_set_drvdata(pdev, priv); > + > + /* status is only updated after reboot */ > + ret = rsu_send_msg(priv, COMMAND_RSU_STATUS, > + 0, rsu_status_callback); > + if (ret) { > + dev_err(dev, "Error getting RSU status (%i)\n", ret); > + stratix10_svc_free_channel(priv->chan); > + return ret; > + } > + > + ret = sysfs_create_group(&dev->kobj, &attr_group); Why not add this to the device earlier so that the driver core creates it all for your automatically? Or does platform devices not do this? I can never remember... > + if (ret) > + stratix10_svc_free_channel(priv->chan); > + > + pr_info("Intel RSU Driver Initialized\n"); Don't be noisy, if all goes well, never say anything. thanks, greg k-h