From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E567CC43218 for ; Fri, 26 Apr 2019 20:08:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEDF2206A3 for ; Fri, 26 Apr 2019 20:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbfDZUIk (ORCPT ); Fri, 26 Apr 2019 16:08:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:54224 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfDZUIj (ORCPT ); Fri, 26 Apr 2019 16:08:39 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 13:08:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="139153816" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga006.jf.intel.com with ESMTP; 26 Apr 2019 13:08:38 -0700 Date: Fri, 26 Apr 2019 13:11:22 -0700 From: Jacob Pan To: Auger Eric Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Christoph Hellwig , Lu Baolu , Andriy Shevchenko , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 10/19] iommu/vt-d: Add custom allocator for IOASID Message-ID: <20190426131122.2093e3ba@jacob-builder> In-Reply-To: <7a79c1cd-eef2-2233-3b31-4d93a6c3b48d@redhat.com> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-11-git-send-email-jacob.jun.pan@linux.intel.com> <7a79c1cd-eef2-2233-3b31-4d93a6c3b48d@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Apr 2019 19:27:26 +0200 Auger Eric wrote: > Hi Jacob, > > On 4/24/19 1:31 AM, Jacob Pan wrote: > > When VT-d driver runs in the guest, PASID allocation must be > > performed via virtual command interface. This patch register a > registers will fix > > custom IOASID allocator which takes precedence over the default > > IDR based allocator. > nit: s/IDR based// . It is xarray based now. right, changed code but not commit message :) > The resulting IOASID allocation will always > > come from the host. This ensures that PASID namespace is system- > > wide. > > > > Signed-off-by: Lu Baolu > > Signed-off-by: Liu, Yi L > > Signed-off-by: Jacob Pan > > --- > > drivers/iommu/intel-iommu.c | 58 > > +++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/intel-iommu.h | 2 ++ 2 files changed, 60 > > insertions(+) > > > > diff --git a/drivers/iommu/intel-iommu.c > > b/drivers/iommu/intel-iommu.c index d93c4bd..ec6f22d 100644 > > --- a/drivers/iommu/intel-iommu.c > > +++ b/drivers/iommu/intel-iommu.c > > @@ -1711,6 +1711,8 @@ static void free_dmar_iommu(struct > > intel_iommu *iommu) if (ecap_prs(iommu->ecap)) > > intel_svm_finish_prq(iommu); > > } > > + ioasid_unregister_allocator(&iommu->pasid_allocator); > > + > > #endif > > } > > > > @@ -4811,6 +4813,46 @@ static int __init > > platform_optin_force_iommu(void) return 1; > > } > > > > +static ioasid_t intel_ioasid_alloc(ioasid_t min, ioasid_t max, > > void *data) +{ > > + struct intel_iommu *iommu = data; > > + ioasid_t ioasid; > > + > > + /* > > + * VT-d virtual command interface always uses the full 20 > > bit > > + * PASID range. Host can partition guest PASID range based > > on > > + * policies but it is out of guest's control. > > + */ > The above comment does not exactly relate to the check below > > + if (min < PASID_MIN || max > PASID_MAX) > > + return -EINVAL; > > + > > + if (vcmd_alloc_pasid(iommu, &ioasid)) > > + return INVALID_IOASID; > > + > > + return ioasid; > > +} > > + > > +static int intel_ioasid_free(ioasid_t ioasid, void *data) > > +{ > > + struct iommu_pasid_alloc_info *svm; > > + struct intel_iommu *iommu = data; > > + > > + if (!iommu || !cap_caching_mode(iommu->cap)) > > + return -EINVAL; > can !cap_caching_mode(iommu->cap) be true as the allocator only is set > if CM? right, should never happen. > > + /* > > + * Sanity check the ioasid owner is done at upper layer, > > e.g. VFIO > > + * We can only free the PASID when all the devices are > > unbond. > > + */ > > + svm = ioasid_find(NULL, ioasid, NULL); > > + if (!svm) { > you can avoid using the local svm variable. > > + pr_warn("Freeing unbond IOASID %d\n", ioasid); > unbound > > + return -EBUSY; > -EINVAL? It meant the PASID is still being used, bond to a device doing DMA etc. thus -EBUSY. But I will make the free a void function. > > + } > > + vcmd_free_pasid(iommu, ioasid); > > + > > + return 0; > > +} > > + > > int __init intel_iommu_init(void) > > { > > int ret = -ENODEV; > > @@ -4912,6 +4954,22 @@ int __init intel_iommu_init(void) > > "%s", iommu->name); > > iommu_device_set_ops(&iommu->iommu, > > &intel_iommu_ops); iommu_device_register(&iommu->iommu); > > + if (cap_caching_mode(iommu->cap) && > > sm_supported(iommu)) { > so shouldn't you test VCCAP_REG as well? > > + /* > > + * Register a custom ASID allocator if we > > are running > > + * in a guest, the purpose is to have a > > system wide PASID > > + * namespace among all PASID users. > > + * There can be multiple vIOMMUs in each > > guest but only > > + * one allocator is active. All vIOMMU > > allocators will > > + * eventually be calling the same host > > allocator. > > + */ > > + iommu->pasid_allocator.alloc = > > intel_ioasid_alloc; > > + iommu->pasid_allocator.free = > > intel_ioasid_free; > > + iommu->pasid_allocator.pdata = (void > > *)iommu; > > + ret = > > ioasid_register_allocator(&iommu->pasid_allocator); > > + if (ret) > > + pr_warn("Custom PASID allocator > > registeration failed\n"); > registration > > + } > > } > > > > bus_set_iommu(&pci_bus_type, &intel_iommu_ops); > > diff --git a/include/linux/intel-iommu.h > > b/include/linux/intel-iommu.h index bff907b..c24c8aa 100644 > > --- a/include/linux/intel-iommu.h > > +++ b/include/linux/intel-iommu.h > > @@ -31,6 +31,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -549,6 +550,7 @@ struct intel_iommu { > > #ifdef CONFIG_INTEL_IOMMU_SVM > > struct page_req_dsc *prq; > > unsigned char prq_name[16]; /* Name for PRQ interrupt */ > > + struct ioasid_allocator pasid_allocator; /* Custom > > allocator for PASIDs */ #endif > > struct q_inval *qi; /* Queued invalidation > > info */ u32 *iommu_state; /* Store iommu states between suspend and > > resume.*/ > > Thanks > > Eric [Jacob Pan]