Re: [PATCH v10 15/18] dt-bindings: counter: ftm-quaddec

Rob Herring
2019-04-26T14:10:32Z

On Tue, Apr 02, 2019 at 03:30:50PM +0900, William Breathitt Gray wrote:
> From: Patrick Havelange <patrick.havelange@essensium.com>
>
> FlexTimer quadrature decoder driver.
>
> Reviewed-by: Esben Haabendal <esben@haabendal.dk>
> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt
>
> diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt
> new file mode 100644
> index 000000000000..4d18cd722074
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt
> @@ -0,0 +1,18 @@
> +FlexTimer Quadrature decoder counter
> +
> +This driver exposes a simple counter for the quadrature decoder mode.
> +
> +Required properties:
> +- compatible: Must be "fsl,ftm-quaddec".

This needs an SoC specific compatible.

> +- reg: Must be set to the memory region of the flextimer.
> +
> +Optional property:
> +- big-endian: Access the device registers in big-endian mode.
> +
> +Example:
> + counter0: counter@29d0000 {
> + compatible = "fsl,ftm-quaddec";
> + reg = <0x0 0x29d0000 0x0 0x10000>;
> + big-endian;
> + status = "disabled";

Don't show status in examples.

> + };
> --
> 2.21.0
>