From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B839C43219 for ; Fri, 26 Apr 2019 14:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 195842084F for ; Fri, 26 Apr 2019 14:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbfDZOpD (ORCPT ); Fri, 26 Apr 2019 10:45:03 -0400 Received: from 8bytes.org ([81.169.241.247]:37860 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfDZOpD (ORCPT ); Fri, 26 Apr 2019 10:45:03 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 2CDFBD91; Fri, 26 Apr 2019 16:45:02 +0200 (CEST) Date: Fri, 26 Apr 2019 16:44:57 +0200 From: Joerg Roedel To: "Gustavo A. R. Silva" Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/dmar: Use struct_size() helper Message-ID: <20190426144457.GH24576@8bytes.org> References: <20190418184624.GA17025@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418184624.GA17025@embeddedor> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 01:46:24PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace code of the following form: > > size = sizeof(*info) + level * sizeof(info->path[0]); > > with: > > size = struct_size(info, path, level); > > Signed-off-by: Gustavo A. R. Silva Applied, thanks.