From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2C0C43219 for ; Fri, 26 Apr 2019 21:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D402B206E0 for ; Fri, 26 Apr 2019 21:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbfDZVGy (ORCPT ); Fri, 26 Apr 2019 17:06:54 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:53625 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfDZVGy (ORCPT ); Fri, 26 Apr 2019 17:06:54 -0400 X-Originating-IP: 90.66.53.80 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 194ECC0006; Fri, 26 Apr 2019 21:06:51 +0000 (UTC) Date: Fri, 26 Apr 2019 23:06:51 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Nicolas Ferre , Claudiu Beznea , Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Message-ID: <20190426210651.GX14604@piout.net> References: <20190402125056.21509-1-alexandre.belloni@bootlin.com> <20190402125056.21509-8-alexandre.belloni@bootlin.com> <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> <20190425203139.GO14604@piout.net> <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com> <20190425211009.GP14604@piout.net> <155622724107.15276.12946928869888731656@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155622724107.15276.12946928869888731656@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2019 14:20:41-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2019-04-25 14:10:09) > > On 25/04/2019 13:58:10-0700, Stephen Boyd wrote: > > > > IIRC two clocks are used by the clocksource and having it as a platform > > > > device make the clocksource driver fail with -EPROBE_DEFER. > > > > > > > > > > Ok. I'll add a comment in the driver. It needs to be > > > CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can > > > be CLK_OF_DECLARE() instead? > > > > It is coming from that comment: > > https://lore.kernel.org/lkml/153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com/ > > > > Maybe I misinterpreted it. > > > > Hmm I was just confused it seems. If you don't have two devices probing > the same DT node with this compatible string then I think it can just be > CLK_OF_DECLARE(). I was thinking that you were running into some sort of > issue where the other driver using this same compatible couldn't probe. > I tried separating it into two initializations and do as much as possible in the platform driver but because the TCB clocks are peripheral clocks that depend on most of the other ones, I didn't find it convenient. This can safely be changed to CLK_OF_DECLARE. I can send v4 if you want. This should probably be changed for the other drivers too. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com