Re: [PATCH v2 1/2] net: phy: realtek: Add rtl8211e rx/tx delays config

Serge Semin
2019-04-28T19:19:11Z

On Sat, Apr 27, 2019 at 05:21:09PM +0200, Andrew Lunn wrote:
> > > >> Hi Serge
> > > >>
> > > >> Next time please include a patch 0 containing a cover note explaining
> > > >> the who series.
> > > >>
> > > >
> > > > Sure as long as the patchset gets to be much bigger than two small
> > > > patches with an obvious reason to be merged.
> > >
> > > netdev likes to have a cover letter for patch count >= 1, probably
> > > something to be added to netdev-FAQ.rst.
> > > --
> > > Florian
> >
> > Hello Florian
> > Really, even with count = 1? So just one patch with cover-letter? Doesn't it
> > seem redundant since at least a single patch can be thoroughly described in
> > it' commit message?
>
> Hi Serge
>
> David workflow is to put the patch set into a branch, and then merge
> the branch into his master, using the cover note as the merge commit
> message.
>
> You occasionally see commit messages for count == 1, but not often.
> For > 1, if there is no cover note, somebody is likely to ask for one
> :-)
>
> Andrew

Hello Andrew and Florian

Alright. I see your point. Though I am not really agree with it at this
situation, the next version of the mini-patchset will be sent with a
cover-letter as per maintainers request.

Meanwhile lets put aside this discussion and get back to the topic-related
one. Could you respond to the email I've sent in response to the Andrew's
comment on the second patch of v2 duet?

-Sergey