From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BD2C43219 for ; Sat, 27 Apr 2019 01:47:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E7A3206BA for ; Sat, 27 Apr 2019 01:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556329656; bh=P0SYwHsozH/6iagqvsGNIJFk3gv2btfITSQrcBJvrNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RWgFFsUMx6V9HTZOkAx/wmySp7GbB5tgeSJ62CvG5YuZaoF+k4prAfxy+CwrysdAS NVsO7oFORaYdtFruRTJYHJlvLs7TtjpLDDHaU9c1AYDbcEhXPKVNCofnG/SjrnXIwk CTvX9LZrzPYbNnFqXZtjzXvf9ToVfEr8qk3g0zLk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728994AbfD0Brf (ORCPT ); Fri, 26 Apr 2019 21:47:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:47088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728121AbfD0Bm6 (ORCPT ); Fri, 26 Apr 2019 21:42:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CE98208CB; Sat, 27 Apr 2019 01:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556329378; bh=P0SYwHsozH/6iagqvsGNIJFk3gv2btfITSQrcBJvrNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aqpz79R14xzGYeERIQ76YRH9awyyRDOwbLJbCCWJUAWP7mfy+fAM4qo4rDMiiwww/ uMRRmEZ36PQ1sIAcnZVZyPXBmo8UyWM4IVvDxLvoK5gnjUQle9yu7wem1xXn7nRvtj YfHOzDOVdz0NKCssR5yZ3IdCF91Si3Yx0xZTnXmY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sugar Zhang , Mark Brown , Sasha Levin , linux-rockchip@lists.infradead.org Subject: [PATCH AUTOSEL 4.14 17/32] ASoC: rockchip: pdm: fix regmap_ops hang issue Date: Fri, 26 Apr 2019 21:42:08 -0400 Message-Id: <20190427014224.8274-17-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190427014224.8274-1-sashal@kernel.org> References: <20190427014224.8274-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sugar Zhang [ Upstream commit c85064435fe7a216ec0f0238ef2b8f7cd850a450 ] This is because set_fmt ops maybe called when PD is off, and in such case, regmap_ops will lead system hang. enale PD before doing regmap_ops. Signed-off-by: Sugar Zhang Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/rockchip/rockchip_pdm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index 400e29edb1c9..8a2e3bbce3a1 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -208,7 +208,9 @@ static int rockchip_pdm_set_fmt(struct snd_soc_dai *cpu_dai, return -EINVAL; } + pm_runtime_get_sync(cpu_dai->dev); regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, mask, val); + pm_runtime_put(cpu_dai->dev); return 0; } -- 2.19.1