Re: [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it

Vladimir Zapolskiy
2019-04-30T20:53:05Z

Hi Enrico,

On 04/27/2019 03:52 PM, Enrico Weigelt, metux IT consult wrote:
> Fill the struct uart_port->mapsize field and use it, insteaf of

typo, s/insteaf/instead/

> hardcoded values in many places. This makes the code layout a bit
> more consistent and easily allows using generic helpers for the
> io memory handling.
>
> Candidates for such helpers could be eg. the request+ioremap and
> iounmap+release combinations.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir