Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

Andy Shevchenko
2019-04-29T15:39:59Z

On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:18, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote:

> >> - int ret = 0;
> >
> > This and Co is a separate change that can be done in its own patch.
>
> I don't really understand :(
> Do you mean the splitting off the retval part from the rest ?

You do two things here: one of them is removing ret and other relative changes.
This should be split to a separate patch.

> > You may increase readability by introducing temporary variables
> >
> > ... mapbase = port->mapbase;
> > ... mapsize = port->mapsize;
> > ...
> > port->membase = ioremap_nocache(mapbase, mapsize);
> > ...
>
> Is that really necessary ? Maybe it's just my personal taste, but I
> don't feel the more more verbose one is really easier to read.

Up to Greg. For me it's harder to read all those port-> in several parameters.

--
With Best Regards,
Andy Shevchenko