Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()

Maciej W. Rozycki
2019-05-01T02:20:42Z

On Mon, 29 Apr 2019, Greg KH wrote:

> > >> drivers/tty/serial/dz.c | 8 ++++----
> > >
> > > Do you have this hardware to test any of these changes with?
> >
> > Unfortunately not :(
>
> Then I can take the "basic" types of patches for the driver (like this
> one), but not any others, sorry.

I can verify changes to dz.c, sb1250-duart.c and zs.c with real hardware,
but regrettably not right away: the hardware is in a remote location and
while I have it wired for remote operation unfortunately its connectivity
has been cut off by an unfriendly ISP.

I'm not sure if all the changes make sense though: if there is a compiler
warning or a usability issue, then a patch is surely welcome, otherwise:
"If it ain't broke, don't fix it".

Maciej