Re: [PATCH 21/41] drivers: tty: serial: cpm_uart: fix includes

Christophe Leroy
2019-04-29T16:03:03Z

Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit :
> Fixing checkpatch warning:
>
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #25: FILE: drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c:25:
> +#include <asm/io.h>
>
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> +#include <asm/io.h>
>
> WARNING: Use #include <linux/delay.h> instead of <asm/delay.h>
> +#include <asm/delay.h>
>
> Signed-off-by: Enrico Weigelt <info@metux.net>

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

> ---
> drivers/tty/serial/cpm_uart/cpm_uart_core.c | 4 ++--
> drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
> index 374b8bb..c831d31 100644
> --- a/drivers/tty/serial/cpm_uart/cpm_uart_core.c
> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
> @@ -33,10 +33,10 @@
> #include <linux/gpio.h>
> #include <linux/of_gpio.h>
> #include <linux/clk.h>
> +#include <linux/io.h>
> +#include <linux/delay.h>
>
> -#include <asm/io.h>
> #include <asm/irq.h>
> -#include <asm/delay.h>
> #include <asm/fs_pd.h>
> #include <asm/udbg.h>
>
> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> index ef1ae08..40cfcf4 100644
> --- a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> @@ -21,8 +21,8 @@
> #include <linux/device.h>
> #include <linux/memblock.h>
> #include <linux/dma-mapping.h>
> +#include <linux/io.h>
>
> -#include <asm/io.h>
> #include <asm/irq.h>
> #include <asm/fs_pd.h>
> #include <asm/prom.h>
>