From: Ondrej Zary <linux@zary.sk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rik Faith <faith@cs.unc.edu>,
"David A . Hinds" <dahinds@users.sourceforge.net>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] fdomain: Resurrect driver (core)
Date: Sun, 28 Apr 2019 21:52:31 +0200 [thread overview]
Message-ID: <201904282152.32077.linux@zary.sk> (raw)
In-Reply-To: <20190424060212.GA5506@infradead.org>
On Wednesday 24 April 2019 08:02:12 Christoph Hellwig wrote:
> > +static void fdomain_work(struct work_struct *work)
> > +{
> > + struct fdomain *fd = container_of(work, struct fdomain, work);
> > + struct Scsi_Host *sh = container_of((void *)fd, struct Scsi_Host,
> > + hostdata);
>
> This looks odd. We should never need a void cast for container_of.
This cast is present in all drivers involving container_of, struct Scsi_Host and hostdata. hostdata in struct Scsi_Host is defined as "unsigned long hostdata[0]"...
--
Ondrej Zary
next prev parent reply other threads:[~2019-04-28 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 17:33 [RFC PATCH 0/4] fdomain: Resurrect driver (modular version) Ondrej Zary
2019-04-22 17:33 ` [RFC PATCH 1/4] fdomain: Resurrect driver (core) Ondrej Zary
2019-04-24 6:02 ` Christoph Hellwig
2019-04-28 19:52 ` Ondrej Zary [this message]
2019-04-29 11:51 ` Christoph Hellwig
2019-04-22 17:33 ` [RFC PATCH 2/4] fdomain: Resurrect driver (PCI support) Ondrej Zary
2019-04-24 6:02 ` Christoph Hellwig
2019-04-22 17:33 ` [RFC PATCH 3/4] fdomain: Resurrect driver (ISA support) Ondrej Zary
2019-04-22 17:33 ` [RFC PATCH 4/4] fdomain: Resurrect driver (PCMCIA support) Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904282152.32077.linux@zary.sk \
--to=linux@zary.sk \
--cc=dahinds@users.sourceforge.net \
--cc=faith@cs.unc.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox