Re: [PATCH 3/4] PCI: pciehp: Remove unused macro definitions

Andy Shevchenko
2019-04-28T15:55:43Z

On Sat, Apr 27, 2019 at 02:13:03PM -0500, fred@fredlawl.com wrote:
> Now that all uses for the ctrl_*() printk wrappers are removed from
> files and replaces with pci_*() or pr_*() printk wrappers, remove the
> unused macro definitions. In addition to that, remove the MY_NAME macro.

> extern bool pciehp_debug;

How it's used after all?

> -#define dbg(format, arg...) \
> -do { \
> - if (pciehp_debug) \
> - printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg); \
> -} while (0)

> -#define ctrl_dbg(ctrl, format, arg...) \
> - do { \
> - if (pciehp_debug) \
> - dev_printk(KERN_DEBUG, &ctrl->pcie->device, \
> - format, ## arg); \
> - } while (0)

Besides ruining the pciehp_debug support this will make unequivalent behaviour.

--
With Best Regards,
Andy Shevchenko