Re: [PATCH 1/4] PCI: Replace dev_*() printk wrappers with pci_*() printk wrappers

Andy Shevchenko
2019-04-28T15:43:49Z

On Sat, Apr 27, 2019 at 02:13:01PM -0500, fred@fredlawl.com wrote:
> From: Frederick Lawler <fred@fredlawl.com>
>
> Replace remaining instances of dev_*() printk wrappers with pci_*()
> printk wrappers. No functional change intended.

> - pci_printk(KERN_DEBUG, parent, "can't find device of ID%04x\n",
> - e_info->id);
> + pci_dbg(parent, "can't find device of ID%04x\n", e_info->id);

These are not equivalent.

> - dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n");
> + pci_dbg(pdev, "alloc AER rpc failed\n");

Ditto.

> - dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
> - dev->irq);
> + pci_dbg(pdev, "request AER IRQ %d failed\n", dev->irq);

Ditto.

And so on.

--
With Best Regards,
Andy Shevchenko