From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287B0C43219 for ; Mon, 29 Apr 2019 08:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F36B1206BF for ; Mon, 29 Apr 2019 08:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727612AbfD2IQu convert rfc822-to-8bit (ORCPT ); Mon, 29 Apr 2019 04:16:50 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:56799 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbfD2IQu (ORCPT ); Mon, 29 Apr 2019 04:16:50 -0400 X-Originating-IP: 90.88.147.33 Received: from xps13 (aaubervilliers-681-1-27-33.w90-88.abo.wanadoo.fr [90.88.147.33]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id BED4CFF81A; Mon, 29 Apr 2019 08:16:45 +0000 (UTC) Date: Mon, 29 Apr 2019 10:16:44 +0200 From: Miquel Raynal To: =?UTF-8?B?UGF3ZcWC?= Chmiel Cc: kyungmin.park@samsung.com, bbrezillon@kernel.org, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tomasz Figa Subject: Re: [PATCH 1/5] mtd: onenand/samsung: Unify resource order for controller variants Message-ID: <20190429101644.7c46c05d@xps13> In-Reply-To: <20190426164224.11327-2-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> <20190426164224.11327-2-pawel.mikolaj.chmiel@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paweł, Paweł Chmiel wrote on Fri, 26 Apr 2019 18:42:20 +0200: > From: Tomasz Figa > > Before this patch, the order of memory resources requested by the driver > was controller base as first and OneNAND chip base as second for > S3C64xx/S5PC100 variant and the opposite for S5PC110/S5PV210 variant. > > To make this more consistent, this patch swaps the order of resources > for the latter and updates platform code accordingly. As a nice side > effect there is a slight reduction in line count of probe function. > > Signed-off-by: Tomasz Figa > Signed-off-by: Paweł Chmiel Thanks for the patch but it looks like you also are renaming fields in the main onenand structure. Maybe it is worth doing it in a preliminary patch. Thanks, Miquèl