From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE252C43219 for ; Mon, 29 Apr 2019 13:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A0EA2084B for ; Mon, 29 Apr 2019 13:10:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="lIpDsbuh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbfD2NKW (ORCPT ); Mon, 29 Apr 2019 09:10:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48511 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfD2NKW (ORCPT ); Mon, 29 Apr 2019 09:10:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aYKtvh8CGD4Fir29/5qEcjjZUDlh8MOEt6C5OW0zFX0=; b=lIpDsbuhS8wthEqycJIffIJRuO noAYg/gVoDvjB3kzDXFB5oOuLHqiwkTg2k7cdgjY4eGBb2JnpiPCLDXnaFjia2+R48Iwsy8qFhZlS wSGaJOkLXAzvsPAN1c/qksACWcdG9JeCJYmRSDuqj0xzJX/lsDzIBbeAU3K9118YoijA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hL62y-0000qn-7g; Mon, 29 Apr 2019 15:10:16 +0200 Date: Mon, 29 Apr 2019 15:10:16 +0200 From: Andrew Lunn To: "Ong, Boon Leong" Cc: "Voon, Weifeng" , "David S. Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Kweh, Hock Leong" , Florian Fainelli , Maxime Coquelin , Giuseppe Cavallaro , Jose Abreu Subject: Re: [PATCH 0/7] net: stmmac: enable EHL SGMII Message-ID: <20190429131016.GE10772@lunn.ch> References: <1556126241-2774-1-git-send-email-weifeng.voon@intel.com> <20190424134854.GP28405@lunn.ch> <20190425123801.GD8117@lunn.ch> <20190425152332.GD23779@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Sorry for the delay, we have checked with hardware/SoC HW architect > and gotten confirmation that the controller can only support SGMII inter-chip > connection. It does not support 1000Base-X. O.K, i'm surprised about that, but if that is what the hardware engineer says... > In this case, we believe that the current implementation of the DW xPCS > are sufficient. Ok? Yes, if all i can do is SGMII, hard coding SGMII is fine. But you should probably check phy-mode and return an error if it has a value other than SGMII, Andrew