From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0DAC43219 for ; Mon, 29 Apr 2019 13:12:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F9FE2053B for ; Mon, 29 Apr 2019 13:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556543549; bh=J2idFfiKv+JvN0+HiaPQqLJ6pzBDj5cmW8lzCb3bYgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kEvB0YTJYTTZ52Uoz4DLzIHsq4qoh+cCP8tG3Tizb8i7NU4EKC+jLsTy4g/09rumk 8j9n2u+8XZQxj3wvWoJdqmPSq46NT/izw9Ax99xUby/b/cOnhibJRDmCNkS7saeYHs Q9iGXZKy6TSj6h0lG0psyB9XfmhWC5W+YaHl8tpo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfD2NM2 (ORCPT ); Mon, 29 Apr 2019 09:12:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:52082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbfD2NM1 (ORCPT ); Mon, 29 Apr 2019 09:12:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99818204EC; Mon, 29 Apr 2019 13:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556543547; bh=J2idFfiKv+JvN0+HiaPQqLJ6pzBDj5cmW8lzCb3bYgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MzcdTgitQcDCbSwcxhk03M1tQV3J+moX/dmENcmLCtQYm92Fb1NTbcvBelaspwjS3 7EhZ/L64SyOs103Zx9B3noQSFfNQShEJSh1FnDlNFg0edwqYu8dCmQ7doTv9L+6hjk bimbOVRgVvccb3YuJyAJqFREv+JGOgKACuX6nLjs= Date: Mon, 29 Apr 2019 15:12:24 +0200 From: Greg KH To: "Enrico Weigelt, metux IT consult" Cc: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk() Message-ID: <20190429131224.GA27385@kroah.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-2-git-send-email-info@metux.net> <20190427133117.GC11368@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2019 at 02:37:04PM +0200, Enrico Weigelt, metux IT consult wrote: > On 27.04.19 15:31, Greg KH wrote: > > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: > >> Using dev_err() instead of printk() for more consistent output. > >> (prints device name, etc). > >> > >> Signed-off-by: Enrico Weigelt > >> --- > >> drivers/tty/serial/dz.c | 8 ++++---- > > > > Do you have this hardware to test any of these changes with? > > Unfortunately not :( Then I can take the "basic" types of patches for the driver (like this one), but not any others, sorry. thanks, greg k-h