From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB713C43219 for ; Mon, 29 Apr 2019 15:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9590B20656 for ; Mon, 29 Apr 2019 15:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728732AbfD2PcD (ORCPT ); Mon, 29 Apr 2019 11:32:03 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:42880 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728249AbfD2PcD (ORCPT ); Mon, 29 Apr 2019 11:32:03 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 9EAEF8063F; Mon, 29 Apr 2019 17:31:51 +0200 (CEST) Date: Mon, 29 Apr 2019 17:32:00 +0200 From: Pavel Machek To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Marek Behun , linux-leds@vger.kernel.org Subject: Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia) Message-ID: <20190429153200.GA11761@amd> References: <20190429190354.0d5e2e93@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-04-29 08:03:02, Randy Dunlap wrote: > On 4/29/19 2:03 AM, Stephen Rothwell wrote: > > Hi all, > >=20 > > Changes since 20190426: > >=20 >=20 > on i386: >=20 > when CONFIG_LEDS_TURRIS_OMNIA=3Dy and CONFIG_I2C=3Dm: >=20 > Probably should also depend on I2C. >=20 >=20 > ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_remove': > leds-turris-omnia.c:(.text+0xb): undefined reference to `i2c_smbus_write_= byte_data' > ld: drivers/leds/leds-turris-omnia.o: in function `omnia_led_brightness_s= et_blocking': > leds-turris-omnia.c:(.text+0x62): undefined reference to `i2c_smbus_write= _byte_data' > ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_probe': > leds-turris-omnia.c:(.text+0x1d8): undefined reference to `i2c_smbus_writ= e_byte_data' > ld: leds-turris-omnia.c:(.text+0x1f6): undefined reference to `i2c_smbus_= write_byte_data' > ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_init= ': > leds-turris-omnia.c:(.init.text+0x8): undefined reference to `i2c_registe= r_driver' > ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_exit= ': > leds-turris-omnia.c:(.exit.text+0x6): undefined reference to `i2c_del_dri= ver' Ack. It can also depend on ARM or even specific ARM soc... unless we are compile testing. This is for specific router... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzHGPAACgkQMOfwapXb+vL9jACcC0cZMF86zp58Y6ZM6xxpAhvi uv4AoKHilquec+zSgoj4f3eT5nker2ID =92aw -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--