From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
"Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 5/5] IB/hfi1: Fix improper uses of smp_mb__before_atomic()
Date: Tue, 30 Apr 2019 01:16:57 +0200 [thread overview]
Message-ID: <20190429231657.GA2733@andrea> (raw)
In-Reply-To: <14063C7AD467DE4B82DEDB5C278E8663BE6AADCE@FMSMSX108.amr.corp.intel.com>
Hi Mike,
> >This barrier only applies to the read-modify-write operations; in
> >particular, it does not apply to the atomic_read() primitive.
> >
> >Replace the barrier with an smp_mb().
>
> This is one of a couple of barrier issues that we are currently looking into.
>
> See:
>
> [PATCH for-next 6/9] IB/rdmavt: Add new completion inline
>
> We will take a look at this one as well.
Thank you for the reference and for looking into this,
Andrea
next prev parent reply other threads:[~2019-04-29 23:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 20:14 [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Andrea Parri
2019-04-29 20:14 ` [PATCH 1/5] drm/msm: " Andrea Parri
2019-05-09 20:19 ` Andrea Parri
2019-04-29 20:14 ` [PATCH 2/5] bio: fix improper use of smp_mb__before_atomic() Andrea Parri
2019-04-30 8:21 ` Peter Zijlstra
2019-05-09 20:23 ` Andrea Parri
2019-05-10 3:40 ` Ming Lei
2019-04-29 20:14 ` [PATCH 3/5] sbitmap: " Andrea Parri
2019-05-09 20:26 ` Andrea Parri
2019-05-10 3:41 ` Ming Lei
2019-05-10 6:27 ` Andrea Parri
2019-04-29 20:15 ` [PATCH 4/5] ceph: " Andrea Parri
2019-04-30 8:23 ` Peter Zijlstra
2019-04-30 9:08 ` Yan, Zheng
2019-05-09 20:55 ` Andrea Parri
2019-05-13 13:04 ` Yan, Zheng
2019-05-13 22:47 ` Andrea Parri
2019-04-29 20:15 ` [PATCH 5/5] IB/hfi1: Fix improper uses " Andrea Parri
2019-04-29 21:24 ` Ruhl, Michael J
2019-04-29 23:16 ` Andrea Parri [this message]
2019-05-09 21:12 ` Andrea Parri
2019-05-14 12:32 ` Dennis Dalessandro
2019-05-14 14:48 ` Andrea Parri
2019-04-30 8:28 ` Peter Zijlstra
2019-04-30 8:34 ` [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Peter Zijlstra
2019-04-30 16:44 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429231657.GA2733@andrea \
--to=andrea.parri@amarulasolutions.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox