From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724D5C04AA6 for ; Tue, 30 Apr 2019 08:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E5F421734 for ; Tue, 30 Apr 2019 08:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556614179; bh=4oEZTyi4cu+wwC6uBvxX94gI4HR+gwXAPqQgJjtgO3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2giFK+PTyVQRnyYGHQQvuI6B/B9wJaPuPv8nkMeYCBCQ3yFhqsXcmy2mj7aEXcEVv 0Bj4FDx2axIycty8PL84ek67AdVKW2l4O75MeBqpOdZSJ6G8kHVLXZ/PtNQqa/avJt /SzVH2mbCfyUt6cjygT0ZbMmTmqHrzvn7RbvNON8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbfD3Iti (ORCPT ); Tue, 30 Apr 2019 04:49:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:58658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfD3Ith (ORCPT ); Tue, 30 Apr 2019 04:49:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6A862080C; Tue, 30 Apr 2019 08:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556614176; bh=4oEZTyi4cu+wwC6uBvxX94gI4HR+gwXAPqQgJjtgO3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vucCDva5kurj0uqHNPIPOHeu6NwpFUJsaFKneIpnjOgJego0/0DLEBJRMkWmbcVPE gYGlA8OX8TLukLQ+w92qNC+/SQ18Ek4rDIWtRdwv3dCWm507Qoauj/ozKgC8afk8gx uYTZTnBZjckAytp4U0ZxbnRYAaJN3QH1/CPyqk4c= Date: Tue, 30 Apr 2019 10:49:33 +0200 From: Greg KH To: Paul Moore Cc: Sasha Levin , Nathan Chancellor , Stephen Smalley , Eric Paris , selinux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nicolas Iooss Subject: Re: scripts/selinux build error in 4.14 after glibc update Message-ID: <20190430084933.GI11737@kroah.com> References: <20190422210041.GA21711@archlinux-i9> <20190423132926.GK17719@sasha-vm> <20190429124002.GB31371@kroah.com> <20190429140906.GA7412@kroah.com> <20190429145248.GA7111@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2019 at 06:37:03PM -0400, Paul Moore wrote: > On Mon, Apr 29, 2019 at 10:52 AM Greg KH wrote: > > On Mon, Apr 29, 2019 at 10:47:00AM -0400, Paul Moore wrote: > > > On Mon, Apr 29, 2019 at 10:09 AM Greg KH wrote: > > > > On Mon, Apr 29, 2019 at 10:02:29AM -0400, Paul Moore wrote: > > > > > On Mon, Apr 29, 2019 at 8:40 AM Greg KH wrote: > > > > > > On Tue, Apr 23, 2019 at 09:43:09AM -0400, Paul Moore wrote: > > > > > > > On Tue, Apr 23, 2019 at 9:29 AM Sasha Levin wrote: > > > > > > > > On Mon, Apr 22, 2019 at 09:59:47PM -0400, Paul Moore wrote: > > > > > > > > >On Mon, Apr 22, 2019 at 5:00 PM Nathan Chancellor > > > > > > > > > wrote: > > > > > > > > >> Hi all, > > > > > > > > >> > > > > > > > > >> After a glibc update to 2.29, my 4.14 builds started failing like so: > > > > > > > > > > > > > > > > > >... > > > > > > > > > > > > > > > > > >> HOSTCC scripts/selinux/genheaders/genheaders > > > > > > > > >> In file included from scripts/selinux/genheaders/genheaders.c:19: > > > > > > > > >> ./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map. > > > > > > > > >> #error New address family defined, please update secclass_map. > > > > > > > > >> ^~~~~ > > > > > > > > > > > > > > > > > >This is a known problem that has a fix in the selinux/next branch and > > > > > > > > >will be going up to Linus during the next merge window. The fix is > > > > > > > > >quite small and should be relatively easy for you to backport to your > > > > > > > > >kernel build if you are interested; the patch can be found at the > > > > > > > > >archive link below: > > > > > > > > > > > > > > > > > >https://lore.kernel.org/selinux/20190225005528.28371-1-paulo@paulo.ac > > > > > > > > > > > > > > > > Why is it waiting for the next merge window? It fixes a build bug that > > > > > > > > people hit. > > > > > > > > > > > > > > I place a reasonably high bar on patches that I send up to Linus > > > > > > > outside of the merge window and I didn't feel this patch met that > > > > > > > criteria. Nathan is only the second person I've seen who has > > > > > > > encountered this problem, the first being the original patch author. > > > > > > > As far as I've seen, the problem is only seen by users building older > > > > > > > kernels on very new userspaces (e.g. glibc v2.29 was released in > > > > > > > February 2019, Linux v4.14 was released in 2017); this doesn't appear > > > > > > > to be a large group of people and I didn't want to risk breaking the > > > > > > > main kernel tree during the -rcX phase for such a small group. > > > > > > > > > > > > Ugh, this breaks my local builds, I would recommend getting it to Linus > > > > > > sooner please. > > > > > > > > > > Well, we are at -rc7 right now and it looks like an -rc8 is unlikely > > > > > so the question really comes down to can/do you want to wait a week? > > > > > > > > It's a regression in the 5.1-rc tree, that is hitting people now. Why > > > > do you want to have a 5.1-final that is known to be broken? > > > > > > I believe I answered that in my reply to Sasha. Can you answer the > > > question I asked of you above? > > > > If you don't submit it this week, I guess I can wait as I have no other > > choice. > > > > But note, this did break my build systems, and my main development > > system this weekend. So yes, the number of people being affected might > > be "small", but that "small" number includes the people responsible for > > maintaining those stable kernels :( > > > > Anyway, it's your call, just letting you know I'm really annoyed at the > > moment by this... > > It's against my better judgement, but I'll send a PR up to Linus now. Thank you for doing so, greg k-h