From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org, eranian@google.com, tj@kernel.org,
ak@linux.intel.com
Subject: Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree
Date: Tue, 30 Apr 2019 11:03:58 +0200 [thread overview]
Message-ID: <20190430090358.GL2623@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1556549045-71814-4-git-send-email-kan.liang@linux.intel.com>
On Mon, Apr 29, 2019 at 07:44:04AM -0700, kan.liang@linux.intel.com wrote:
> +static struct perf_event *
> +perf_event_groups_first_cgroup(struct perf_event_groups *groups,
> + int cpu, u64 cgrp_id)
> +{
> + struct perf_event *node_event = NULL, *match = NULL;
> + struct rb_node *node = groups->tree.rb_node;
> +
> + while (node) {
> + node_event = container_of(node, struct perf_event, group_node);
> +
> + if (cpu < node_event->cpu) {
> + node = node->rb_left;
> + } else if (cpu > node_event->cpu) {
> + node = node->rb_right;
> + } else {
> + if (cgrp_id_low(cgrp_id) < cgrp_id_low(node_event->cgrp_id))
> + node = node->rb_left;
> + else if (cgrp_id_low(cgrp_id) > cgrp_id_low(node_event->cgrp_id))
> + node = node->rb_right;
> + else {
> + match = node_event;
> + node = node->rb_left;
> + }
> + }
> + }
> + return match;
> +}
That's whitespace challenged.
next prev parent reply other threads:[~2019-04-30 9:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:44 [PATCH 0/4] Optimize cgroup context switch kan.liang
2019-04-29 14:44 ` [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring kan.liang
2019-04-29 15:04 ` Mark Rutland
2019-04-29 15:27 ` Liang, Kan
2019-04-30 8:56 ` Peter Zijlstra
2019-04-30 15:45 ` Liang, Kan
2019-04-29 14:44 ` [PATCH 2/4] perf: Add filter_match() as a parameter for pinned/flexible_sched_in() kan.liang
2019-04-29 15:12 ` Mark Rutland
2019-04-29 15:31 ` Liang, Kan
2019-04-29 16:56 ` Mark Rutland
2019-04-29 14:44 ` [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree kan.liang
2019-04-29 23:02 ` Ian Rogers
2019-04-30 9:08 ` Peter Zijlstra
2019-04-30 15:46 ` Liang, Kan
2019-04-30 9:03 ` Peter Zijlstra
2019-04-30 15:46 ` Liang, Kan
2019-04-30 9:03 ` Peter Zijlstra [this message]
2019-04-29 14:44 ` [PATCH 4/4] perf cgroup: Add fast path for cgroup switch kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430090358.GL2623@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox