* [PATCH] kernel/module: Reschedule while waiting for modules to finish loading
@ 2019-04-29 15:17 Prarit Bhargava
2019-04-30 7:51 ` Jessica Yu
2019-04-30 12:16 ` Jessica Yu
0 siblings, 2 replies; 5+ messages in thread
From: Prarit Bhargava @ 2019-04-29 15:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Prarit Bhargava, Jessica Yu
Heiko, do you want a Signed-off-by or a Reported-by? Either one works
for me.
P.
----8<----
On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
loading the s390_trng.ko module.
Add a reschedule point to the loop that waits for modules to complete
loading.
Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Jessica Yu <jeyu@kernel.org>
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index 410eeb7e4f1d..48748cfec991 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
finished_loading(mod->name));
if (err)
goto out_unlocked;
+ cond_resched();
goto again;
}
err = -EEXIST;
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading
2019-04-29 15:17 [PATCH] kernel/module: Reschedule while waiting for modules to finish loading Prarit Bhargava
@ 2019-04-30 7:51 ` Jessica Yu
2019-04-30 9:16 ` Heiko Carstens
2019-04-30 11:28 ` Prarit Bhargava
2019-04-30 12:16 ` Jessica Yu
1 sibling, 2 replies; 5+ messages in thread
From: Jessica Yu @ 2019-04-30 7:51 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: Heiko Carstens, linux-kernel
+++ Prarit Bhargava [29/04/19 11:17 -0400]:
>Heiko, do you want a Signed-off-by or a Reported-by? Either one works
>for me.
>
>P.
I think you forgot to CC Heiko :)
>----8<----
>
>On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
>loading the s390_trng.ko module.
>
>Add a reschedule point to the loop that waits for modules to complete
>loading.
>
>Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
>Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>Cc: Jessica Yu <jeyu@kernel.org>
>---
> kernel/module.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index 410eeb7e4f1d..48748cfec991 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
> finished_loading(mod->name));
> if (err)
> goto out_unlocked;
>+ cond_resched();
> goto again;
> }
> err = -EEXIST;
>--
>2.18.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading
2019-04-30 7:51 ` Jessica Yu
@ 2019-04-30 9:16 ` Heiko Carstens
2019-04-30 11:28 ` Prarit Bhargava
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Carstens @ 2019-04-30 9:16 UTC (permalink / raw)
To: Jessica Yu; +Cc: Prarit Bhargava, linux-kernel
On Tue, Apr 30, 2019 at 09:51:08AM +0200, Jessica Yu wrote:
> +++ Prarit Bhargava [29/04/19 11:17 -0400]:
> >Heiko, do you want a Signed-off-by or a Reported-by? Either one works
> >for me.
> >
> >P.
>
> I think you forgot to CC Heiko :)
Indeed ;)
I'm fine with the Reported-by tag. Thank you!
> >----8<----
> >
> >On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
> >loading the s390_trng.ko module.
> >
> >Add a reschedule point to the loop that waits for modules to complete
> >loading.
> >
> >Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> >Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
> >Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> >Cc: Jessica Yu <jeyu@kernel.org>
> >---
> >kernel/module.c | 1 +
> >1 file changed, 1 insertion(+)
> >
> >diff --git a/kernel/module.c b/kernel/module.c
> >index 410eeb7e4f1d..48748cfec991 100644
> >--- a/kernel/module.c
> >+++ b/kernel/module.c
> >@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
> > finished_loading(mod->name));
> > if (err)
> > goto out_unlocked;
> >+ cond_resched();
> > goto again;
> > }
> > err = -EEXIST;
> >--
> >2.18.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading
2019-04-30 7:51 ` Jessica Yu
2019-04-30 9:16 ` Heiko Carstens
@ 2019-04-30 11:28 ` Prarit Bhargava
1 sibling, 0 replies; 5+ messages in thread
From: Prarit Bhargava @ 2019-04-30 11:28 UTC (permalink / raw)
To: Jessica Yu; +Cc: Heiko Carstens, linux-kernel
On 4/30/19 3:51 AM, Jessica Yu wrote:
> +++ Prarit Bhargava [29/04/19 11:17 -0400]:
>> Heiko, do you want a Signed-off-by or a Reported-by? Either one works
>> for me.
>>
>> P.
>
> I think you forgot to CC Heiko :)
#oops.
I forgot that git-send-email doesn't pick up "Reported-by".
P.
>
>> ----8<----
>>
>> On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
>> loading the s390_trng.ko module.
>>
>> Add a reschedule point to the loop that waits for modules to complete
>> loading.
>>
>> Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>> Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for
>> modules that have finished loading")
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>> Cc: Jessica Yu <jeyu@kernel.org>
>> ---
>> kernel/module.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/module.c b/kernel/module.c
>> index 410eeb7e4f1d..48748cfec991 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
>> finished_loading(mod->name));
>> if (err)
>> goto out_unlocked;
>> + cond_resched();
>> goto again;
>> }
>> err = -EEXIST;
>> --
>> 2.18.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading
2019-04-29 15:17 [PATCH] kernel/module: Reschedule while waiting for modules to finish loading Prarit Bhargava
2019-04-30 7:51 ` Jessica Yu
@ 2019-04-30 12:16 ` Jessica Yu
1 sibling, 0 replies; 5+ messages in thread
From: Jessica Yu @ 2019-04-30 12:16 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: linux-kernel
+++ Prarit Bhargava [29/04/19 11:17 -0400]:
>Heiko, do you want a Signed-off-by or a Reported-by? Either one works
>for me.
>
>P.
>
>----8<----
>
>On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
>loading the s390_trng.ko module.
>
>Add a reschedule point to the loop that waits for modules to complete
>loading.
>
>Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
>Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>Cc: Jessica Yu <jeyu@kernel.org>
Thanks for the fix! Applied to modules-next.
Jessica
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-30 12:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-29 15:17 [PATCH] kernel/module: Reschedule while waiting for modules to finish loading Prarit Bhargava
2019-04-30 7:51 ` Jessica Yu
2019-04-30 9:16 ` Heiko Carstens
2019-04-30 11:28 ` Prarit Bhargava
2019-04-30 12:16 ` Jessica Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).