From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C008C43219 for ; Tue, 30 Apr 2019 10:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4C6E21670 for ; Tue, 30 Apr 2019 10:08:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SIAxZnZS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbfD3KIP (ORCPT ); Tue, 30 Apr 2019 06:08:15 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:38198 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbfD3KIP (ORCPT ); Tue, 30 Apr 2019 06:08:15 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3UA3aJt033304; Tue, 30 Apr 2019 10:08:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=dtQuBl11xaoPJLNvvxMye/1ZO950lVHHUMyKYmwkh1A=; b=SIAxZnZSCBpTf7tgn/j+IY5iaIyvYA8Lelb2DAMR012RT++g8W2T46OjEkO4vCURd6Uk AzNVWiq8dIy5VP6aF9iHfJ96WK0lUl4pxezIBS+v5U+mOLhbqMeWnNejMX/uHolLQAYX 7jFgZ6cq7F3MLdW1pnvUxtr3+nwh9Ak6nHFfoUf7jIAgGshQUtwsxQdmii8KeD0lCCWl Y3xSHlvhxrfKMcPttqjSa6TMTZJ02uCGvXLshHTSudf4GsSVuDX2FBkWmK+Ada9c9BZV IlsoAx+ZIl/osFpLeG4EGhc4Hq6wAz8Cm0QnKrJNzbXOq1KBtf4KdoJkVoS4krscee0q Nw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2s5j5u08pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Apr 2019 10:08:02 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3UA6fOE062168; Tue, 30 Apr 2019 10:08:01 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2s4d4ae54v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Apr 2019 10:08:01 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3UA7w5r017407; Tue, 30 Apr 2019 10:08:00 GMT Received: from kadam (/196.97.65.153) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 30 Apr 2019 03:07:57 -0700 Date: Tue, 30 Apr 2019 13:07:50 +0300 From: Dan Carpenter To: Nicholas Mc Guire Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Matt Sickler , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V2] staging: kpc2000: use int for wait_for_completion_interruptible Message-ID: <20190430100750.GE2269@kadam> References: <1556356474-8575-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556356474-8575-1-git-send-email-hofrat@osadl.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300067 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 27, 2019 at 11:14:34AM +0200, Nicholas Mc Guire wrote: > weit_for_completion_interruptible returns in (0 on completion and ^ wait_for_completion_interruptible > -ERESTARTSYS on interruption) - so use an int not long for API conformance > and simplify the logic here a bit: need not check explicitly for == 0 as > this is either -ERESTARTSYS or 0. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with experimental API conformance checking cocci script > > V2: kbuild reported a missing closing comment - seems that I managed > send out the the initial version before compile testing/checkpatching > sorry for the noise. > > Not sure if making such point-wise fixes makes much sense - this driver has > a number of issues both style-wise and API compliance wise. > > Note that kpc_dma_transfer() returns int not long - currently rv (long) is > being returned in most places (some places do return int) - so the return > handling here is a bit inconsistent. > > Patch was compile-tested with: x86_64_defconfig + KPC2000=y, KPC2000_DMA=y > (with a number of unrelated sparse warnings about non-declared symbols, and > smatch warnings about overflowing constants as well as coccicheck warning > about usless casting) > > Patch is against 5.1-rc6 (localversion-next is next-20190426) > > drivers/staging/kpc2000/kpc_dma/fileops.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c > index 5741d2b..66f0d5a 100644 > --- a/drivers/staging/kpc2000/kpc_dma/fileops.c > +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c > @@ -38,6 +38,7 @@ int kpc_dma_transfer(struct dev_private_data *priv, struct kiocb *kcb, unsigned > { > unsigned int i = 0; > long rv = 0; > + int ret = 0; This assignment is never used. It just turns static checking for uninitialized variable bugs. > struct kpc_dma_device *ldev; > struct aio_cb_data *acd; > DECLARE_COMPLETION_ONSTACK(done); > @@ -180,16 +181,17 @@ int kpc_dma_transfer(struct dev_private_data *priv, struct kiocb *kcb, unsigned > > // If this is a synchronous kiocb, we need to put the calling process to sleep until the transfer is complete > if (kcb == NULL || is_sync_kiocb(kcb)){ > - rv = wait_for_completion_interruptible(&done); > - // If the user aborted (rv == -ERESTARTSYS), we're no longer responsible for cleaning up the acd > - if (rv == -ERESTARTSYS){ > + ret = wait_for_completion_interruptible(&done); > + /* If the user aborted (ret == -ERESTARTSYS), we're > + * no longer responsible for cleaning up the acd > + */ > + if (ret) { > acd->cpl = NULL; > - } > - if (rv == 0){ > - rv = acd->len; > + } else { > + ret = acd->len; "acd->len" is a size_t (unsigned long) so probably we should just change the type of kpc_dma_transfer to ssize_t actually. regards, dan carpenter