Re: [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel

Pierre Morel
2019-04-30T11:01:06Z

On 30/04/2019 11:37, Halil Pasic wrote:
> On Tue, 30 Apr 2019 10:32:52 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>>>>> +    aqic_gisa.gisa = gisa->next_alert >> 4;
>>>>
>>>> Why gisa->next_alert? Isn't this supposed to get set to gisa origin
>>>> (without some bits on the left)?
>
> s/left/right/
>
>>>
>>> Someone already asked this question.
>
> It must have been in some previous iteration... Can you give me a
> pointer?
>
>>> The answer is: look at the ap_qirq_ctrl structure, you will see that the
>>> gisa field is 27 bits wide.
>
> My question was not about the width, but about gisa->next_alert being
> used.
>
> Regards,
> Halil
>

Ah, OK, I understand.
it is inherited from the time I allocated the GISA myself, before the
Mimu GISA/GIB patches.

So now indeed I must use the GISA origin for the case next_alert is used
by GIB alert queue.

--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany