From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB984C43219 for ; Tue, 30 Apr 2019 18:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AEE921734 for ; Tue, 30 Apr 2019 18:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556648644; bh=9oaD9A4M16f814eUiYybr55q9veyq6DrGjdRObx772s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZFXwlK1UVhURnLbQf8t8PeKIE1pH0at4d9zZ/PXHnsdkir9hdl/pVVWdMJFYgccNt zgnlPwmaplzw7lxNbWEGg1TiXtL28pHhoohF9Y69idfSmaq7qqLOOZCWF8Qm3DXQuI LTKY9HvASt8Da3AQD3WqZSBGoEtJN3ffch3vkRvA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbfD3SYD (ORCPT ); Tue, 30 Apr 2019 14:24:03 -0400 Received: from mga06.intel.com ([134.134.136.31]:35329 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfD3SYC (ORCPT ); Tue, 30 Apr 2019 14:24:02 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2019 11:24:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,414,1549958400"; d="scan'208";a="169379061" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga001.fm.intel.com with ESMTP; 30 Apr 2019 11:24:01 -0700 Date: Tue, 30 Apr 2019 12:18:13 -0600 From: Keith Busch To: Bjorn Helgaas Cc: Alex G , Lukas Wunner , Alex Williamson , Austin Bolen , Alexandru Gagniuc , Keith Busch , Shyam Iyer , Sinan Kaya , Linus Torvalds , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification" Message-ID: <20190430181813.GC25654@localhost.localdomain> References: <20190429185611.121751-1-helgaas@kernel.org> <20190429185611.121751-2-helgaas@kernel.org> <20190430161151.GB145057@google.com> <20190430180508.GB25654@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430180508.GB25654@localhost.localdomain> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 12:05:09PM -0600, Keith Busch wrote: > On Tue, Apr 30, 2019 at 11:11:51AM -0500, Bjorn Helgaas wrote: > > > I'm not convinced a revert is the best call. > > > > I have very limited options at this stage of the release, but I'd be > > glad to hear suggestions. My concern is that if we release v5.1 > > as-is, we'll spend a lot of energy on those false positives. > > May be too late now if the revert is queued up, but I think this feature > should have been a default 'false' Kconfig bool rather than always on. This is what I mean: --- diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index 5cbdbca904ac..7f480685df93 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -142,3 +142,12 @@ config PCIE_PTM This is only useful if you have devices that support PTM, but it is safe to enable even if you don't. + +config PCIE_BW + bool "PCI Express Bandwidth Change Notification" + default n + depends on PCIEPORTBUS + help + This enables PCI Express Bandwidth Change Notification. If + you know link width or rate changes occur only to correct + unreliable links, you may answer Y. diff --git a/drivers/pci/pcie/Makefile b/drivers/pci/pcie/Makefile index f1d7bc1e5efa..d356a5bdb158 100644 --- a/drivers/pci/pcie/Makefile +++ b/drivers/pci/pcie/Makefile @@ -3,7 +3,6 @@ # Makefile for PCI Express features and port driver pcieportdrv-y := portdrv_core.o portdrv_pci.o err.o -pcieportdrv-y += bw_notification.o obj-$(CONFIG_PCIEPORTBUS) += pcieportdrv.o @@ -13,3 +12,4 @@ obj-$(CONFIG_PCIEAER_INJECT) += aer_inject.o obj-$(CONFIG_PCIE_PME) += pme.o obj-$(CONFIG_PCIE_DPC) += dpc.o obj-$(CONFIG_PCIE_PTM) += ptm.o +obj-$(CONFIG_PCIE_BW) := bw_notification.o --