From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450EEC43219 for ; Tue, 30 Apr 2019 22:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C73120835 for ; Tue, 30 Apr 2019 22:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbfD3WI5 (ORCPT ); Tue, 30 Apr 2019 18:08:57 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54569 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbfD3WI5 (ORCPT ); Tue, 30 Apr 2019 18:08:57 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id DDF6C8085B; Wed, 1 May 2019 00:08:46 +0200 (CEST) Date: Wed, 1 May 2019 00:08:56 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Message-ID: <20190430220855.GD20410@amd> References: <20190430191730.19450-1-dmurphy@ti.com> <20190430191730.19450-6-dmurphy@ti.com> <20190430220527.GC20410@amd> <34f72f44-9385-a42a-4e44-94ae6a04fe98@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4" Content-Disposition: inline In-Reply-To: <34f72f44-9385-a42a-4e44-94ae6a04fe98@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6Nae48J/T25AfBN4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2019-04-30 17:07:32, Dan Murphy wrote: >=20 >=20 > On 4/30/19 5:05 PM, Pavel Machek wrote: > > On Tue 2019-04-30 14:17:28, Dan Murphy wrote: > >> The LM3697 is a single function LED driver. The single function LED > >> driver needs to reside in the LED directory as a dedicated LED driver > >> and not as a MFD device. The device does have common brightness and r= amp > >> features and those can be accomodated by a TI LMU framework. > >> > >> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedi= cated > >> LED dt binding needs to be added. The new LM3697 LED dt binding will = then > >> reside in the Documentation/devicetree/bindings/leds directory and fol= low the > >> current LED and general bindings guidelines. > >> > >> Reviewed-by: Rob Herring > >> Signed-off-by: Dan Murphy > >> --- > >> > >> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchw= ork/patch/1058762/ > >> > >> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.= txt - > >> https://lore.kernel.org/patchwork/patch/1054501/ > >> > >> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++ > >> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------ > >> 2 files changed, 74 insertions(+), 26 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697= =2Etxt > >> > >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/= Documentation/devicetree/bindings/leds/leds-lm3697.txt > >> new file mode 100644 > >> index 000000000000..02378f33c9ab > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt > >> @@ -0,0 +1,73 @@ > >> +* Texas Instruments - LM3697 Highly Efficient White LED Driver > >> + > >> +The LM3697 11-bit LED driver provides high- > >> +performance backlight dimming for 1, 2, or 3 series > >> +LED strings while delivering up to 90% efficiency. > >> + > >> +This device is suitable for display and keypad Lighting > >=20 > > "lightning." >=20 > Heh. Don't think you meant lightning but I get what you are saying >=20 > s/Lighting/lighting Yep. Sorry :-). Plus I'd add a dot (".") at the end of sentence. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --6Nae48J/T25AfBN4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzIx3cACgkQMOfwapXb+vIXwACgojs3hh1JSW3TwopZNKqVtCfI Pb4Anj8CVBzVheWZyoaalsSvGtnILLTd =tNRY -----END PGP SIGNATURE----- --6Nae48J/T25AfBN4--