From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB2FC43219 for ; Wed, 1 May 2019 01:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A2A421743 for ; Wed, 1 May 2019 01:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tiw+3vW/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbfEABHJ (ORCPT ); Tue, 30 Apr 2019 21:07:09 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45684 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727514AbfEABGv (ORCPT ); Tue, 30 Apr 2019 21:06:51 -0400 Received: by mail-pg1-f194.google.com with SMTP id i21so4204679pgi.12 for ; Tue, 30 Apr 2019 18:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yW25BIpw+3OdLrz2ZA6bQCaxdj/ZNzRUZJYjM1RP07U=; b=tiw+3vW/xxGdEdVQeatzmXTfVuogkzZBodBCn8i10QdmiHdpiuKNmOIzbFj/lGWaEU omHsStfCtPyxVQR0mUcLN7MBvJskP/61dOLBl+Vg3DBmTjStMmkbCUg2EyCaR4p1NKLR p+3ycGH9rzLatFO2VJbk12e71aLkL0ATFhmWBaAhR3lIsjhRXob80GjATLBZ1UEs4Z4r RrDTT4aZEjvtSzp58qMvy8X8hwFiAewX7nMHOu8MGg//ZmbR/tdTVak2TWYZGMT5J3G2 JOOsptdALjpKS2p2G4838hJis1a0kefqDRE7i6rZdkQ2J/jM3YL2jYsmKec4EBBcBmma isoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yW25BIpw+3OdLrz2ZA6bQCaxdj/ZNzRUZJYjM1RP07U=; b=eVdI1cBpVcjG9dHXLPE1si5I4FbeMwfFfrihklz4nmNG0TPbwItYwdTY1UwbrMIlHu 7C8Vbjt4OBTzVyhSvbsruQLzKCNl5E++WtHODP0ivUHew424ijH4Yb/xvDuI98aPizRp fUy+FLVEW2ddi1TAiy6VFFWk84lgmTV72DvaFwmsCUCmB5G/Cpkra5NqEI+2MNLYE1AA VntRKcaAnCYvvBAfsXb2G0U4rX3epsZ6prmYrEU+4rjdzvgJ9SbmTrD262x9rVOrzZJa DsVkSK5nSHYPOjDqMOAHZxka/7BeI6QnCASRgI/Kw00yI/bwsMwueAWAbevxOjdJWFMA pPpg== X-Gm-Message-State: APjAAAWKzffyiTSu2AuS/BXSvLwF5vNISaLngesv5AcaaP2gGaGUEtJs MCwBBI0luLI8PiWsu5wVSy8= X-Google-Smtp-Source: APXvYqz4M+QQmOmmCEQmONTF8EZI8GdJ3Xwm5c3zOwzBAg/JaIZesYp5e2BWI4rzee6ckJP+tTO7Hw== X-Received: by 2002:a65:534b:: with SMTP id w11mr11874654pgr.210.1556672810728; Tue, 30 Apr 2019 18:06:50 -0700 (PDT) Received: from localhost ([2601:640:7:332f:bc53:6e04:b584:e900]) by smtp.gmail.com with ESMTPSA id b5sm3931194pfo.153.2019.04.30.18.06.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 18:06:50 -0700 (PDT) From: Yury Norov X-Google-Original-From: Yury Norov To: Andrew Morton , Andy Shevchenko , Rasmus Villemoes , Dmitry Torokhov , "David S . Miller" , Stephen Rothwell , Amritha Nambiar , Willem de Bruijn , Kees Cook , Matthew Wilcox , "Tobin C . Harding" , Will Deacon , Miklos Szeredi , Vineet Gupta , Chris Wilson , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org Cc: Yury Norov , Yury Norov , Jens Axboe , Steffen Klassert Subject: [PATCH 4/7] lib: make bitmap_parse_user a wrapper on bitmap_parse Date: Tue, 30 Apr 2019 18:06:33 -0700 Message-Id: <20190501010636.30595-5-ynorov@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190501010636.30595-1-ynorov@marvell.com> References: <20190501010636.30595-1-ynorov@marvell.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently we parse user data byte after byte which leads to overcomplicating of parsing algorithm. There are no performance critical users of bitmap_parse_user(), and so we can duplicate user data to kernel buffer and simply call bitmap_parselist(). This rework lets us unify and simplify bitmap_parse() and bitmap_parse_user(), which is done in the following patch. Signed-off-by: Yury Norov --- lib/bitmap.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/bitmap.c b/lib/bitmap.c index f235434df87b..300732031fad 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -434,22 +434,22 @@ EXPORT_SYMBOL(__bitmap_parse); * then it must be terminated with a \0. * @maskp: pointer to bitmap array that will contain result. * @nmaskbits: size of bitmap, in bits. - * - * Wrapper for __bitmap_parse(), providing it with user buffer. - * - * We cannot have this as an inline function in bitmap.h because it needs - * linux/uaccess.h to get the access_ok() declaration and this causes - * cyclic dependencies. */ int bitmap_parse_user(const char __user *ubuf, unsigned int ulen, unsigned long *maskp, int nmaskbits) { - if (!access_ok(ubuf, ulen)) - return -EFAULT; - return __bitmap_parse((const char __force *)ubuf, - ulen, 1, maskp, nmaskbits); + char *buf; + int ret; + buf = memdup_user_nul(ubuf, ulen); + if (IS_ERR(buf)) + return PTR_ERR(buf); + + ret = bitmap_parse(buf, ulen, maskp, nmaskbits); + + kfree(buf); + return ret; } EXPORT_SYMBOL(bitmap_parse_user); -- 2.17.1