From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5D6C43219 for ; Wed, 1 May 2019 12:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4396B2075E for ; Wed, 1 May 2019 12:37:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="gWkzZcyE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726434AbfEAMhz (ORCPT ); Wed, 1 May 2019 08:37:55 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50911 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfEAMhz (ORCPT ); Wed, 1 May 2019 08:37:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m0uIUv9YcB2rBMJ6vazLEXNKZm0mfkTXXnCh6q5+fEc=; b=gWkzZcyE8qpTPXGdKfBs5Ya1+d UYiAlBNAbGOCKKSiMeBpBQ8xvKq6cIWlaa7gKMIaeDYWGFGQMaMdioCOJkYfnMCs/YVIUPsz8CaCG Q4YTmOc9Jw+g76NvIdEjmrGYFKmzTEfr+ubOG8iTZwnP1KqNH0QQHi5c1DI9K+JF9DVQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hLoUg-0002l7-JG; Wed, 01 May 2019 14:37:50 +0200 Date: Wed, 1 May 2019 14:37:50 +0200 From: Andrew Lunn To: Peng Li Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH net-next 1/3] net: hns3: add support for multiple media type Message-ID: <20190501123750.GA9844@lunn.ch> References: <1556679944-100941-1-git-send-email-lipeng321@huawei.com> <1556679944-100941-2-git-send-email-lipeng321@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556679944-100941-2-git-send-email-lipeng321@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 01, 2019 at 11:05:42AM +0800, Peng Li wrote: > From: Jian Shen > > Previously, we can only identify copper and fiber type, the > supported link modes of port information are always showing > SR type. This patch adds support for multiple media types, > include SR, LR CR, KR. Driver needs to query the media type > from firmware periodicly, and updates the port information. > > The new port information looks like this: > Settings for eth0: > Supported ports: [ FIBRE ] > Supported link modes: 25000baseCR/Full > 25000baseSR/Full > 1000baseX/Full > 10000baseCR/Full > 10000baseSR/Full > 10000baseLR/Full > Supported pause frame use: Symmetric > Supports auto-negotiation: No > Supported FEC modes: None BaseR > Advertised link modes: 25000baseCR/Full > 25000baseSR/Full > 1000baseX/Full > 10000baseCR/Full > 10000baseSR/Full > 10000baseLR/Full Hi Peng If it does not support auto-negotiation, do these advertised link modes make any sense? Does it really advertise, or is it all fixed configured? Andrew