From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
liam.r.girdwood@linux.intel.com, jank@cadence.com,
joe@perches.com, srinivas.kandagatla@linaro.org,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH v4 02/22] soundwire: fix SPDX license for header files
Date: Wed, 1 May 2019 18:05:03 +0200 [thread overview]
Message-ID: <20190501160503.GB19281@kroah.com> (raw)
In-Reply-To: <20190501155745.21806-3-pierre-louis.bossart@linux.intel.com>
On Wed, May 01, 2019 at 10:57:25AM -0500, Pierre-Louis Bossart wrote:
> No C++ comments in .h files
That's not really the issue here.
>
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/bus.h | 4 ++--
> drivers/soundwire/cadence_master.h | 4 ++--
> drivers/soundwire/intel.h | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h
> index c77de05b8100..2f8436584e7f 100644
> --- a/drivers/soundwire/bus.h
> +++ b/drivers/soundwire/bus.h
> @@ -1,5 +1,5 @@
> -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
> -// Copyright(c) 2015-17 Intel Corporation.
> +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
> +/* Copyright(c) 2015-17 Intel Corporation. */
The first line is fine to change, as that was the requirement (although
I think it has now been fixed), the second line is just taste, whatever
you want, it's not a requirement.
But I really don't care, it's not my code :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-01 16:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:57 [PATCH v4 00/22] soundwire: code cleanup Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 01/22] soundwire: Kconfig: fix help format Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 02/22] soundwire: fix SPDX license for header files Pierre-Louis Bossart
2019-05-01 16:05 ` Greg KH [this message]
2019-05-02 5:16 ` Vinod Koul
2019-05-02 6:31 ` Greg KH
2019-05-02 6:44 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 03/22] soundwire: fix alignment issues in " Pierre-Louis Bossart
2019-05-02 5:25 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 04/22] soundwire: bus: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 05/22] soundwire: bus: fix typos in comments Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 06/22] soundwire: bus: remove useless parentheses Pierre-Louis Bossart
2019-05-02 5:32 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 07/22] soundwire: bus: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 08/22] soundwire: bus: remove spurious newline Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 09/22] soundwire: bus_type: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 10/22] soundwire: mipi_disco: " Pierre-Louis Bossart
2019-05-02 5:34 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 11/22] soundwire: mipi_disco: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 12/22] soundwire: stream: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 13/22] soundwire: slave: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 14/22] soundwire: intel_init: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 15/22] soundwire: intel: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 16/22] soundwire: intel: protect macro parameters Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 17/22] soundwire: intel: fix boolean comparison Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 18/22] soundwire: cadence_master: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 19/22] soundwire: cadence_master: balance parentheses Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 20/22] soundwire: cadence_master: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 21/22] soundwire: cadence_master: remove spurious newline Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 22/22] soundwire: add missing newlines in dynamic debug logs Pierre-Louis Bossart
2019-05-02 5:37 ` Vinod Koul
2019-05-02 6:32 ` Greg KH
2019-05-02 14:55 ` [alsa-devel] " Pierre-Louis Bossart
2019-05-01 16:07 ` [PATCH v4 00/22] soundwire: code cleanup Greg KH
2019-05-02 5:39 ` Vinod Koul
2019-05-02 5:58 ` Vinod Koul
2019-05-02 7:07 ` [alsa-devel] " Vinod Koul
2019-05-02 15:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501160503.GB19281@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jank@cadence.com \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox