Re: [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node

Jeffrey Hugo
2019-05-01T14:18:02Z

On 4/30/2019 9:35 PM, Bjorn Andersson wrote:
> On Tue 30 Apr 19:25 PDT 2019, Jeffrey Hugo wrote:
>
>> GCC is a consumer of the xo clock. Add a reference to the clock supplier
>> to the gcc node.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> (Although I prefer clock-names following clocks)

Huh, I didn't even realize I did that until you pointed it out. Feel
free to adjust when you apply, or if there is another spin I'll fix it.

>
> Regards,
> Bjorn
>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 574be78..9c88801 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -709,6 +709,8 @@
>> #reset-cells = <1>;
>> #power-domain-cells = <1>;
>> reg = <0x100000 0xb0000>;
>> + clock-names = "xo";
>> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
>> };
>>
>> tlmm: pinctrl@3400000 {
>> --
>> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
>> Qualcomm Technologies, Inc. is a member of the
>> Code Aurora Forum, a Linux Foundation Collaborative Project.
>>

--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.