From: Tony Lindgren <tony@atomide.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "kernelci.org bot" <bot@kernelci.org>, Tejun Heo <tj@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
tomeu.vizoso@collabora.com, guillaume.tucker@collabora.com,
mgalka@collabora.com, Thomas Gleixner <tglx@linutronix.de>,
broonie@kernel.org, matthew.hart@linaro.org,
khilman@baylibre.com, enric.balletbo@collabora.com,
Ingo Molnar <mingo@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Kevin Hilman <khilman@kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: next/master boot bisection: next-20190430 on beagle-xm
Date: Wed, 1 May 2019 13:21:49 -0700 [thread overview]
Message-ID: <20190501202149.GM8007@atomide.com> (raw)
In-Reply-To: <20190501190303.pz2yxs3hnc2qpamu@linutronix.de>
Hi,
* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [190501 19:03]:
> On 2019-05-01 10:44:31 [-0700], Tony Lindgren wrote:
> > Hmm so I tried without "earlycon" in command line thinking it might be
> > happening with just "earlyprintk" but still no luck.
> >
> > BTW, in general you might want to update your kernel command line
> > options to:
> >
> > debug earlyprintk earlycon
>
> debug. Let me look if I manage to hide that `debug' from systemd…
Oh that.. I've been quite happy with openrc now for years :)
> > Looking at the oops 0xfa1cc000, so 0x481cc000 I guess which is d_can0?
>
> That node around it I guess.
OK I found two issues. It seems that d_can also needs osc clock
on am335x. And there's no revision register for d_can.. We're now
reading the CTL register unnecessarily.
Below is what I hope fixes the boot issue for you, care to boot
test?
If this helps I'll send out proper patches for for both issues.
Regards,
Tony
8< ----------------------
diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -1762,8 +1762,9 @@
reg = <0xcc000 0x4>;
reg-names = "rev";
/* Domains (P, C): per_pwrdm, l4ls_clkdm */
- clocks = <&l4ls_clkctrl AM3_L4LS_D_CAN0_CLKCTRL 0>;
- clock-names = "fck";
+ clocks = <&l4ls_clkctrl AM3_L4LS_D_CAN0_CLKCTRL 0>,
+ <&dcan0_fck>;
+ clock-names = "fck", "osc";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0xcc000 0x2000>;
@@ -1785,8 +1786,9 @@
reg = <0xd0000 0x4>;
reg-names = "rev";
/* Domains (P, C): per_pwrdm, l4ls_clkdm */
- clocks = <&l4ls_clkctrl AM3_L4LS_D_CAN1_CLKCTRL 0>;
- clock-names = "fck";
+ clocks = <&l4ls_clkctrl AM3_L4LS_D_CAN1_CLKCTRL 0>,
+ <&dcan1_fck>;
+ clock-names = "fck", "osc";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0xd0000 0x2000>;
next prev parent reply other threads:[~2019-05-01 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 20:51 next/master boot bisection: next-20190430 on beagle-xm kernelci.org bot
2019-05-01 15:37 ` Sebastian Andrzej Siewior
2019-05-01 16:29 ` Tony Lindgren
2019-05-01 16:44 ` Sebastian Andrzej Siewior
2019-05-01 16:52 ` Tony Lindgren
2019-05-01 17:01 ` Sebastian Andrzej Siewior
2019-05-01 17:44 ` Tony Lindgren
2019-05-01 19:03 ` Sebastian Andrzej Siewior
2019-05-01 20:21 ` Tony Lindgren [this message]
2019-05-01 21:13 ` Sebastian Andrzej Siewior
2019-05-01 21:17 ` Tony Lindgren
2019-05-01 21:48 ` Kevin Hilman
2019-05-02 7:16 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501202149.GM8007@atomide.com \
--to=tony@atomide.com \
--cc=bigeasy@linutronix.de \
--cc=bot@kernelci.org \
--cc=broonie@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=guillaume.tucker@collabora.com \
--cc=hannes@cmpxchg.org \
--cc=jiangshanlai@gmail.com \
--cc=khilman@baylibre.com \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthew.hart@linaro.org \
--cc=mgalka@collabora.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox