From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A41C43219 for ; Thu, 2 May 2019 02:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19A1F20645 for ; Thu, 2 May 2019 02:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556764812; bh=m7MBD0pGD4dH1Z8Q6MimgyDC5kDpndLD0a7AWuWAhvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=z3moL315TgAB3QVbeCcIYlzhN+FYw3eXxxrNadNGcdoa/y0NoP/NDQalAdDmKEpvN CQMsfLXjshZJHmVgNBneMfaMDYX3hgbCPuNU1FSal6Svv64869ZtFP0RP9ZyJKwu7W nxaG7AwtXZYWIld8c89CDbgBB4M9ivRhPmSSTbls= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbfEBCkA (ORCPT ); Wed, 1 May 2019 22:40:00 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33649 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfEBCj7 (ORCPT ); Wed, 1 May 2019 22:39:59 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 08CAB65B; Wed, 1 May 2019 22:32:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 01 May 2019 22:32:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=+mDlg6YvPp3wklf/jmi7xhv9NAzlQtv203GvlNGu7hE=; b=X3YaRQmG yGfcYyrs9kPmuNJ3iPRDB196t3mez3ij3blf2Q6K06cpOJ6Yq5Zt+KlELPycbjIq 3OGW9cWu1fhHJ1aiJuo3DOgJQNypm1J8CgWSvRO3Po2I+O3wbt+UETv8jXlLi3oC khDkKQpqYZeGXuBbOZLsiViQTxhD0NkiCgaXl3Y8mcjgHlXs/wzUea9Uc2PeHZGC b21XpIC7eifgX3n0G06yUIh4H5tagEIOmHzG6MHUtCQvacJf+4OPcxYyaueMnskX Un7BREBbVf7Ai1Nm/TJJI5m79KiZGb1/4SufqAC0Is9oaymMrRxBbTcEnYFl15AJ WvwOP6SmfcTOIQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieekgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepfdfvohgsihhn ucevrdcujfgrrhguihhnghdfuceothhosghinheskhgvrhhnvghlrdhorhhgqeenucfkph epuddvuddrgeegrddvtdegrddvfeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgs ihhnsehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from eros.localdomain (ppp121-44-204-235.bras1.syd2.internode.on.net [121.44.204.235]) by mail.messagingengine.com (Postfix) with ESMTPA id 3ED4BE40C4; Wed, 1 May 2019 22:32:30 -0400 (EDT) From: "Tobin C. Harding" To: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Greg Kroah-Hartman Cc: "Tobin C. Harding" , "Rafael J. Wysocki" , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 1/5] livepatch: Fix kobject memleak Date: Thu, 2 May 2019 12:31:38 +1000 Message-Id: <20190502023142.20139-2-tobin@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502023142.20139-1-tobin@kernel.org> References: <20190502023142.20139-1-tobin@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding --- kernel/livepatch/core.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index eb0ee10a1981..98295de2172b 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -727,7 +727,9 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func) ret = kobject_init_and_add(&func->kobj, &klp_ktype_func, &obj->kobj, "%s,%lu", func->old_name, func->old_sympos ? func->old_sympos : 1); - if (!ret) + if (ret) + kobject_put(&func->kobj); + else func->kobj_added = true; return ret; @@ -803,8 +805,10 @@ static int klp_init_object(struct klp_patch *patch, struct klp_object *obj) name = klp_is_module(obj) ? obj->name : "vmlinux"; ret = kobject_init_and_add(&obj->kobj, &klp_ktype_object, &patch->kobj, "%s", name); - if (ret) + if (ret) { + kobject_put(&obj->kobj); return ret; + } obj->kobj_added = true; klp_for_each_func(obj, func) { @@ -862,8 +866,10 @@ static int klp_init_patch(struct klp_patch *patch) ret = kobject_init_and_add(&patch->kobj, &klp_ktype_patch, klp_root_kobj, "%s", patch->mod->name); - if (ret) + if (ret) { + kobject_put(&patch->kobj); return ret; + } patch->kobj_added = true; if (patch->replace) { -- 2.21.0