From: Greg KH <gregkh@linuxfoundation.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org,
liam.r.girdwood@linux.intel.com, jank@cadence.com,
joe@perches.com, srinivas.kandagatla@linaro.org,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH v4 22/22] soundwire: add missing newlines in dynamic debug logs
Date: Thu, 2 May 2019 08:32:19 +0200 [thread overview]
Message-ID: <20190502063219.GB14347@kroah.com> (raw)
In-Reply-To: <20190502053746.GE3845@vkoul-mobl.Dlink>
On Thu, May 02, 2019 at 11:07:46AM +0530, Vinod Koul wrote:
> On 01-05-19, 10:57, Pierre-Louis Bossart wrote:
> > For some reason the newlines are not used everywhere. Fix as needed.
> >
> > Reported-by: Joe Perches <joe@perches.com>
> > Reviewed-by: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > ---
> > drivers/soundwire/bus.c | 74 +++++++++----------
> > drivers/soundwire/cadence_master.c | 12 ++--
> > drivers/soundwire/intel.c | 12 ++--
> > drivers/soundwire/stream.c | 110 ++++++++++++++---------------
>
> Sorry this needs to be split up. I think bus.c and stream.c should go
> in patch with cadence_master.c and intel.c in different ones
Again, _way_ too picky. You can't look a gift horse _too_ closely in
the mouth...
greg k-h
next prev parent reply other threads:[~2019-05-02 6:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:57 [PATCH v4 00/22] soundwire: code cleanup Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 01/22] soundwire: Kconfig: fix help format Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 02/22] soundwire: fix SPDX license for header files Pierre-Louis Bossart
2019-05-01 16:05 ` Greg KH
2019-05-02 5:16 ` Vinod Koul
2019-05-02 6:31 ` Greg KH
2019-05-02 6:44 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 03/22] soundwire: fix alignment issues in " Pierre-Louis Bossart
2019-05-02 5:25 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 04/22] soundwire: bus: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 05/22] soundwire: bus: fix typos in comments Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 06/22] soundwire: bus: remove useless parentheses Pierre-Louis Bossart
2019-05-02 5:32 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 07/22] soundwire: bus: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 08/22] soundwire: bus: remove spurious newline Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 09/22] soundwire: bus_type: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 10/22] soundwire: mipi_disco: " Pierre-Louis Bossart
2019-05-02 5:34 ` Vinod Koul
2019-05-01 15:57 ` [PATCH v4 11/22] soundwire: mipi_disco: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 12/22] soundwire: stream: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 13/22] soundwire: slave: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 14/22] soundwire: intel_init: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 15/22] soundwire: intel: " Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 16/22] soundwire: intel: protect macro parameters Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 17/22] soundwire: intel: fix boolean comparison Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 18/22] soundwire: cadence_master: fix alignment issues Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 19/22] soundwire: cadence_master: balance parentheses Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 20/22] soundwire: cadence_master: fix boolean comparisons Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 21/22] soundwire: cadence_master: remove spurious newline Pierre-Louis Bossart
2019-05-01 15:57 ` [PATCH v4 22/22] soundwire: add missing newlines in dynamic debug logs Pierre-Louis Bossart
2019-05-02 5:37 ` Vinod Koul
2019-05-02 6:32 ` Greg KH [this message]
2019-05-02 14:55 ` [alsa-devel] " Pierre-Louis Bossart
2019-05-01 16:07 ` [PATCH v4 00/22] soundwire: code cleanup Greg KH
2019-05-02 5:39 ` Vinod Koul
2019-05-02 5:58 ` Vinod Koul
2019-05-02 7:07 ` [alsa-devel] " Vinod Koul
2019-05-02 15:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502063219.GB14347@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jank@cadence.com \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox