From: Nikitas Angelinas <nikitas.angelinas@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: nikitas.angelinas@gmail.com
Subject: [PATCH] power/poweroff.c: mark variables with __initdata and __maybe_unused
Date: Thu, 2 May 2019 00:43:05 -0700 [thread overview]
Message-ID: <20190502074305.GA6039@vostro> (raw)
There is no need to keep sysrq_poweroff_op after initialization, so mark
it with __initdata. Mark some of the function parameters with __maybe_unused
to avoid compilation warnings.
Signed-off-by: Nikitas Angelinas <nikitas.angelinas@gmail.com>
---
kernel/power/poweroff.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c
index 7ef6866..d507152 100644
--- a/kernel/power/poweroff.c
+++ b/kernel/power/poweroff.c
@@ -11,26 +11,27 @@
#include <linux/workqueue.h>
#include <linux/reboot.h>
#include <linux/cpumask.h>
+#include <linux/compiler_attributes.h>
/*
* When the user hits Sys-Rq o to power down the machine this is the
* callback we use.
*/
-static void do_poweroff(struct work_struct *dummy)
+static void do_poweroff(struct work_struct *dummy __maybe_unused)
{
kernel_power_off();
}
static DECLARE_WORK(poweroff_work, do_poweroff);
-static void handle_poweroff(int key)
+static void handle_poweroff(int key __maybe_unused)
{
/* run sysrq poweroff on boot cpu */
schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work);
}
-static struct sysrq_key_op sysrq_poweroff_op = {
+static struct sysrq_key_op sysrq_poweroff_op __initdata = {
.handler = handle_poweroff,
.help_msg = "poweroff(o)",
.action_msg = "Power Off",
--
2.10.0
next reply other threads:[~2019-05-02 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 7:43 Nikitas Angelinas [this message]
2019-05-02 10:15 ` [PATCH] power/poweroff.c: mark variables with __initdata and __maybe_unused Pavel Machek
2019-05-02 17:59 ` Nikitas Angelinas
2019-05-02 18:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502074305.GA6039@vostro \
--to=nikitas.angelinas@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox