From: "Petr Štetiar" <ynezz@true.cz>
To: Rob Herring <robh@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Alban Bedel <albeu@free.fr>, Felix Fietkau <nbd@nbd.name>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH v2 1/4] of_net: Add NVMEM support to of_get_mac_address
Date: Thu, 2 May 2019 11:05:38 +0200 [thread overview]
Message-ID: <20190502090538.GD346@meh.true.cz> (raw)
In-Reply-To: <20190501201925.GA15495@bogus>
Rob Herring <robh@kernel.org> [2019-05-01 15:19:25]:
Hi Rob,
> > + struct property *pp;
...
> > + pp = kzalloc(sizeof(*pp), GFP_KERNEL);
> > + if (!pp)
> > + return NULL;
> > +
> > + pp->name = "nvmem-mac-address";
> > + pp->length = ETH_ALEN;
> > + pp->value = kmemdup(mac, ETH_ALEN, GFP_KERNEL);
> > + if (!pp->value || of_add_property(np, pp))
> > + goto free;
>
> Why add this to the DT?
I've just carried it over from v1 ("of_net: add mtd-mac-address support to
of_get_mac_address()")[1] as nobody objected about this so far.
Honestly I don't know if it's necessary to have it, but so far address,
mac-address and local-mac-address properties provide this DT nodes, so I've
simply thought, that it would be good to have it for MAC address from NVMEM as
well in order to stay consistent.
Just FYI, my testing ar9331_8dev_carambola2.dts[2] currently produces
following runtime DT content:
root@OpenWrt:/# find /sys/firmware/devicetree/ -name *nvmem* -o -name *addr@*
/sys/firmware/devicetree/base/ahb/spi@1f000000/flash@0/partitions/partition@ff0000/nvmem-cells
/sys/firmware/devicetree/base/ahb/spi@1f000000/flash@0/partitions/partition@ff0000/nvmem-cells/eth-mac-addr@0
/sys/firmware/devicetree/base/ahb/spi@1f000000/flash@0/partitions/partition@ff0000/nvmem-cells/eth-mac-addr@6
/sys/firmware/devicetree/base/ahb/spi@1f000000/flash@0/partitions/partition@ff0000/nvmem-cells/wifi-mac-addr@1002
/sys/firmware/devicetree/base/ahb/wmac@18100000/nvmem-cells
/sys/firmware/devicetree/base/ahb/wmac@18100000/nvmem-mac-address
/sys/firmware/devicetree/base/ahb/wmac@18100000/nvmem-cell-names
/sys/firmware/devicetree/base/ahb/eth@1a000000/nvmem-cells
/sys/firmware/devicetree/base/ahb/eth@1a000000/nvmem-mac-address
/sys/firmware/devicetree/base/ahb/eth@1a000000/nvmem-cell-names
/sys/firmware/devicetree/base/ahb/eth@19000000/nvmem-cells
/sys/firmware/devicetree/base/ahb/eth@19000000/nvmem-mac-address
/sys/firmware/devicetree/base/ahb/eth@19000000/nvmem-cell-names
root@OpenWrt:/# hexdump -C /sys/firmware/devicetree/base/ahb/wmac@18100000/nvmem-mac-address
00000000 00 03 7f 11 52 da |....R.|
00000006
root@OpenWrt:/# ip addr show wlan0
4: wlan0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000
link/ether 00:03:7f:11:52:da brd ff:ff:ff:ff:ff:ff
1. https://patchwork.ozlabs.org/patch/1086628/
2. https://git.openwrt.org/?p=openwrt/staging/ynezz.git;a=blob;f=target/linux/ath79/dts/ar9331_8dev_carambola2.dts;h=349c91e760ca5a56d65c587c949fed5fb6ea980e;hb=349c91e760ca5a56d65c587c949fed5fb6ea980e
> You have the struct device ptr, so just use devm_kzalloc() if you need an
> allocation.
I'll address this in v3, thanks.
-- ynezz
next prev parent reply other threads:[~2019-05-02 9:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 12:53 [PATCH v2 0/4] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar
2019-04-28 12:53 ` [PATCH v2 1/4] " Petr Štetiar
2019-05-01 20:19 ` Rob Herring
2019-05-02 9:05 ` Petr Štetiar [this message]
2019-05-07 16:06 ` Rob Herring
2019-05-08 9:02 ` Petr Štetiar
2019-04-28 12:53 ` [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-04-28 16:53 ` Andrew Lunn
2019-05-01 20:22 ` Rob Herring
2019-04-28 12:53 ` [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage Petr Štetiar
2019-04-28 16:56 ` Andrew Lunn
2019-04-28 21:08 ` Petr Štetiar
2019-04-28 21:36 ` Andrew Lunn
2019-04-29 7:55 ` Petr Štetiar
2019-04-29 13:02 ` Andrew Lunn
2019-04-30 14:13 ` Handling of EPROBE_DEFER in of_get_mac_address [Was: Re: [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage] Petr Štetiar
2019-05-01 13:54 ` Andrew Lunn
2019-04-28 12:53 ` [PATCH v2 4/4] net: davinci_emac: Drop nvmem_get_mac_address usage Petr Štetiar
2019-04-28 16:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502090538.GD346@meh.true.cz \
--to=ynezz@true.cz \
--cc=albeu@free.fr \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox