From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E134C43219 for ; Thu, 2 May 2019 11:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B04320873 for ; Thu, 2 May 2019 11:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556797725; bh=NxECKS4hO+fvuuCrWF9YKIVWO4SJGdSkM8vdKG2zimY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e/jgzKZoSz/dnBxuVHiHiD1kmJby377VAXaz8Qhbd/HCfrBM2EwHnB6DYnFEMROz1 71fOvvlFsxgMeXCrY8k2NRnOwSs5X/YDLiS+nZ+/DISBSKxUSK+4oiY+LSgmCEq8KN K00lJoeD+iQA1X1BSwOVUVhjOozedxwsBL0bVYSQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfEBLso (ORCPT ); Thu, 2 May 2019 07:48:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:33214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfEBLsm (ORCPT ); Thu, 2 May 2019 07:48:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22F972081C; Thu, 2 May 2019 11:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556797721; bh=NxECKS4hO+fvuuCrWF9YKIVWO4SJGdSkM8vdKG2zimY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ds5BuqKmOB7afrbcN0Xt+UHtJ8ipUSsJUzAyDjWk1qH1nzsBNaeQIfRIwDfKi1m2K BTNO7v+q/sQLq5BPkz4ktdAm71+ks5/iTh6GtHvxLKz5bSrAnqFFSP+A1gLPEROOdz rUh42R8UgAsbD26YA8QbjexKESx/pQc0k30YZH5s= Date: Thu, 2 May 2019 13:48:39 +0200 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Mika Westerberg , "Schmauss, Erik" , mh@mike.franken.de, Lukas Wunner , Takashi Iwai , Bjorn Helgaas , ckellner@redhat.com, Jiri Slaby , Linux Kernel Mailing List , "Rafael J. Wysocki" , Furquan Shaikh , ACPI Devel Maling List , Robert Moore Subject: Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt) Message-ID: <20190502114839.GC24696@kroah.com> References: <20190430090021.GF26516@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 11:37:48AM +0200, Rafael J. Wysocki wrote: > On Tue, Apr 30, 2019 at 11:00 AM Mika Westerberg > wrote: > > > > +Rafael, Furquan and linux-acpi > > > > (The original thread is here https://lore.kernel.org/lkml/s5hy33siofw.wl-tiwai@suse.de/T/#u) > > > > On Tue, Apr 30, 2019 at 10:39:00AM +0200, Michael Hirmke wrote: > > > Hi Takashi, > > > > > > [...] > > > >>> I also have XPS 9370 but not that particular dock. I will check tomorrow > > > >>> if I can reproduce it as well. > > > >> > > > >> There aren't too many changes between 5.0.7 and 5.0.8 that touch > > > >> PCI/ACPI. This is just a shot in the dark but could you try to revert: > > > >> > > > >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi > > > >> t/commit/?h=linux-5.0.y&id=da6a87fb0ad43ae811519d2e0aa325c7f792b13a > > > >> > > > >> and see if it makes any difference? > > > > > > >OK, I'm building a test kernel package with the revert in OBS > > > >home:tiwai:bsc1133486 repo. A new kernel will be > > > >kernel-default-5.0.10-*g8edeab8: > > > > http://download.opensuse.org/repositories/home:/tiwai:/bsc1133486/standard/ > > > > > > >Michael, once when the new kernel is ready, please give it a try. > > > > > > as far as I can see, state is back to normal with this kernel. > > > No more error messages or crashing modules and all devices seem to work > > > as expected. > > > Only thing is, that the external devices connected to the Thunderbolt > > > dock are coming up a little bit slower than with 5.0.7 - but this is > > > nothing, I'd worry about. > > > > Thanks for testing. > > > > Rafael, it seems that commit c8b1917c8987 ("ACPICA: Clear status of GPEs > > before enabling them") causes problem with Thunderbolt controllers if > > you boot with device (dock) connected. > > > > I think the reason is the same that got fixed in v4.14 with commit > > ecc1165b8b74 ("ACPICA: Dispatch active GPEs at init time") which the > > above commit essentially undoes if I understand it correctly. > > OK, I'll queue up a revert of that one then, thanks! > > Erik, I think that commit c8b1917c8987 has been picked up by the > upstream ACPICA already. If I'm not mistaken, it needs to be reverted > from there as well. I've queued the revert up in the stable trees as it has hit Linus's tree now, and will push out a new round of stable kernels soon. thanks, greg k-h