[PATCH 0/1] Add several Beckhoff Automation boards to critclk_systems DMI table

[PATCH 0/1] Add several Beckhoff Automation boards to critclk_systems DMI table

[linux-kernel-dev]

From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>

There are several Beckhoff Automation industrial PC boards which use
pmc_plt_clk* clocks for ethernet controllers. The patch adds affected boards
to critclk_systems DMI table so the clocks are marked as CLK_CRITICAL and
not turned off.
This should be applied on top of another patch as both change
the same table:
[PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to critclk_systems DMI table

Steffen Dirkwinkel (1):
  platform/x86: pmc_atom: Add several Beckhoff Automation boards to
    critclk_systems DMI table

 drivers/platform/x86/pmc_atom.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.21.0

[PATCH 1/1] platform/x86: pmc_atom: Add several Beckhoff Automation boards to critclk_systems DMI table

[linux-kernel-dev]

From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>

There are several Beckhoff Automation industrial PC boards which use
pmc_plt_clk* clocks for ethernet controllers. This adds affected boards
to critclk_systems DMI table so the clocks are marked as CLK_CRITICAL and
not turned off.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
---
 drivers/platform/x86/pmc_atom.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index a311f48ce7c9..b1d804376237 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -413,6 +413,30 @@ static const struct dmi_system_id critclk_systems[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
 		},
 	},
+	{
+		/* pmc_plt_clk* - are used for ethernet controllers */
+		.ident = "Beckhoff CB3163",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Beckhoff Automation"),
+			DMI_MATCH(DMI_BOARD_NAME, "CB3163"),
+		},
+	},
+	{
+		/* pmc_plt_clk* - are used for ethernet controllers */
+		.ident = "Beckhoff CB6263",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Beckhoff Automation"),
+			DMI_MATCH(DMI_BOARD_NAME, "CB6263"),
+		},
+	},
+	{
+		/* pmc_plt_clk* - are used for ethernet controllers */
+		.ident = "Beckhoff CB6363",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Beckhoff Automation"),
+			DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
+		},
+	},
 	{ /*sentinel*/ }
 };
 
-- 
2.21.0

Re: [PATCH 0/1] Add several Beckhoff Automation boards to critclk_systems DMI table

[Andy Shevchenko]

On Thu, May 2, 2019 at 4:04 PM <linux-kernel-dev@beckhoff.com> wrote:
>
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>
> There are several Beckhoff Automation industrial PC boards which use
> pmc_plt_clk* clocks for ethernet controllers. The patch adds affected boards
> to critclk_systems DMI table so the clocks are marked as CLK_CRITICAL and
> not turned off.
> This should be applied on top of another patch as both change
> the same table:
> [PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to critclk_systems DMI table

Yes, that's why it either should go via CLK tree, or I need an
immutable tag or branch from them.
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

>
> Steffen Dirkwinkel (1):
>   platform/x86: pmc_atom: Add several Beckhoff Automation boards to
>     critclk_systems DMI table
>
>  drivers/platform/x86/pmc_atom.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> --
> 2.21.0



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/1] Add several Beckhoff Automation boards to critclk_systems DMI table

[Hans de Goede]

Hi,

On 06-05-19 14:40, Andy Shevchenko wrote:
> On Thu, May 2, 2019 at 4:04 PM <linux-kernel-dev@beckhoff.com> wrote:
>>
>> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>>
>> There are several Beckhoff Automation industrial PC boards which use
>> pmc_plt_clk* clocks for ethernet controllers. The patch adds affected boards
>> to critclk_systems DMI table so the clocks are marked as CLK_CRITICAL and
>> not turned off.
>> This should be applied on top of another patch as both change
>> the same table:
>> [PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to critclk_systems DMI table
> 
> Yes, that's why it either should go via CLK tree, or I need an
> immutable tag or branch from them.
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

As I just mentioned in your reply to the "[PATCH] platform/x86: pmc_atom:
Add Lex 3I380D industrial PC to critclk_systems DMI table":

"Stephen added the patches this depends on to his fixes branch, so they
are in the 5.1 / Torvald's master branch, since we are now in the 5.2 merge
window, you should be able to cleanly apply this directly."

So both that patch and this patch should be able to go through the d-p-x86 tree
unless I'm missing something?

Regards,

Hans

> 
>>
>> Steffen Dirkwinkel (1):
>>    platform/x86: pmc_atom: Add several Beckhoff Automation boards to
>>      critclk_systems DMI table
>>
>>   drivers/platform/x86/pmc_atom.c | 24 ++++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>
>> --
>> 2.21.0
> 
> 
>