[PATCH] drm/amd/powerplay: remove spurious semicolon

[PATCH] drm/amd/powerplay: remove spurious semicolon

[Andrea Righi]

Remove unnecessary semicolons at the end of line.

Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 8 ++++----
 drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index 3f73f7cd18b9..1052f5119087 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -1304,7 +1304,7 @@ static int pp_notify_smu_enable_pwe(void *handle)
 
 	if (hwmgr->hwmgr_func->smus_notify_pwe == NULL) {
 		pr_info_ratelimited("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1341,7 +1341,7 @@ static int pp_set_min_deep_sleep_dcefclk(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_min_deep_sleep_dcefclk == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1360,7 +1360,7 @@ static int pp_set_hard_min_dcefclk_by_freq(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_hard_min_dcefclk_by_freq == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1379,7 +1379,7 @@ static int pp_set_hard_min_fclk_by_freq(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_hard_min_fclk_by_freq == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
index c1c51c115e57..70f7f47a2fcf 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
@@ -76,7 +76,7 @@ int phm_set_power_state(struct pp_hwmgr *hwmgr,
 int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)
 {
 	struct amdgpu_device *adev = NULL;
-	int ret = -EINVAL;;
+	int ret = -EINVAL;
 	PHM_FUNC_CHECK(hwmgr);
 	adev = hwmgr->adev;
 
-- 
2.20.1

RE: [PATCH] drm/amd/powerplay: remove spurious semicolon

[Quan, Evan]

Reviewed-by: Evan Quan <evan.quan@amd.com>

> -----Original Message-----
> From: Andrea Righi <andrea.righi@canonical.com>
> Sent: 2019年5月4日 0:56
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>
> Cc: Rex Zhu <rex.zhu@amd.com>; Wu, Hersen <hersenxs.wu@amd.com>;
> Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org; dri-
> devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amd/powerplay: remove spurious semicolon
> 
> [CAUTION: External Email]
> 
> Remove unnecessary semicolons at the end of line.
> 
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
> ---
>  drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 8 ++++----
>  drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index 3f73f7cd18b9..1052f5119087 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -1304,7 +1304,7 @@ static int pp_notify_smu_enable_pwe(void
> *handle)
> 
>         if (hwmgr->hwmgr_func->smus_notify_pwe == NULL) {
>                 pr_info_ratelimited("%s was not implemented.\n", __func__);
> -               return -EINVAL;;
> +               return -EINVAL;
>         }
> 
>         mutex_lock(&hwmgr->smu_lock);
> @@ -1341,7 +1341,7 @@ static int pp_set_min_deep_sleep_dcefclk(void
> *handle, uint32_t clock)
> 
>         if (hwmgr->hwmgr_func->set_min_deep_sleep_dcefclk == NULL) {
>                 pr_debug("%s was not implemented.\n", __func__);
> -               return -EINVAL;;
> +               return -EINVAL;
>         }
> 
>         mutex_lock(&hwmgr->smu_lock);
> @@ -1360,7 +1360,7 @@ static int pp_set_hard_min_dcefclk_by_freq(void
> *handle, uint32_t clock)
> 
>         if (hwmgr->hwmgr_func->set_hard_min_dcefclk_by_freq == NULL) {
>                 pr_debug("%s was not implemented.\n", __func__);
> -               return -EINVAL;;
> +               return -EINVAL;
>         }
> 
>         mutex_lock(&hwmgr->smu_lock);
> @@ -1379,7 +1379,7 @@ static int pp_set_hard_min_fclk_by_freq(void
> *handle, uint32_t clock)
> 
>         if (hwmgr->hwmgr_func->set_hard_min_fclk_by_freq == NULL) {
>                 pr_debug("%s was not implemented.\n", __func__);
> -               return -EINVAL;;
> +               return -EINVAL;
>         }
> 
>         mutex_lock(&hwmgr->smu_lock);
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
> index c1c51c115e57..70f7f47a2fcf 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
> @@ -76,7 +76,7 @@ int phm_set_power_state(struct pp_hwmgr *hwmgr,
> int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)  {
>         struct amdgpu_device *adev = NULL;
> -       int ret = -EINVAL;;
> +       int ret = -EINVAL;
>         PHM_FUNC_CHECK(hwmgr);
>         adev = hwmgr->adev;
> 
> --
> 2.20.1