From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C190C43219 for ; Sat, 4 May 2019 07:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C81FE2085A for ; Sat, 4 May 2019 07:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556953503; bh=GYMXpi3hhHh/1tqU7eEVtX31z+AYgLC6wQ6uJbd1GEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rZ/2ZmSa5AYPGi7tvaiAM9SdaDPpBzQBVeR3ZtrvToQFqdtIcC1F2mAlJugwZwf3C lrwI5COqy4Qf+XYmPHA6jIDzSJabGOzGIlmqu6qPcdLIyweyeVU5aoksz07WjTytRN z4GkDcgD7ev+G1R3QrPfbSaRLFBX/EHP+7Vygduw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbfEDHFC (ORCPT ); Sat, 4 May 2019 03:05:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:43038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbfEDHFC (ORCPT ); Sat, 4 May 2019 03:05:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 627EF206BB; Sat, 4 May 2019 07:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556953500; bh=GYMXpi3hhHh/1tqU7eEVtX31z+AYgLC6wQ6uJbd1GEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PZZs1eREhw6NBIq6VuDvQDiXChEU1fAUR8k089j7LxfPzqXH7j/9P/wcidcxS7/T1 4Zyu9CNSaglckP1Paujudy8lLQv/SaKOBQP6SqOTz2w3cmU9rAondYmwBsbfIrYY/x x8Ipof+Kgkk0VD3SEU/2w8xV4pR5yd+kHO677tOg= Date: Sat, 4 May 2019 09:04:58 +0200 From: Greg KH To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org, Sanyog Kale Subject: Re: [RFC PATCH 7/7] soundwire: intel: add debugfs register dump Message-ID: <20190504070458.GG9770@kroah.com> References: <20190504010030.29233-1-pierre-louis.bossart@linux.intel.com> <20190504010030.29233-8-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190504010030.29233-8-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 03, 2019 at 08:00:30PM -0500, Pierre-Louis Bossart wrote: > Add debugfs file to dump the Intel SoundWire registers > > Credits: this patch is based on an earlier internal contribution by > Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change > is the use of scnprintf to avoid known issues with snprintf. > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/intel.c | 115 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 4ac141730b13..7fb2cd6d5bb5 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -16,6 +17,7 @@ > #include > #include > #include "cadence_master.h" > +#include "bus.h" > #include "intel.h" > > /* Intel SHIM Registers Definition */ > @@ -98,6 +100,7 @@ struct sdw_intel { > struct sdw_cdns cdns; > int instance; > struct sdw_intel_link_res *res; > + struct dentry *fs; > }; > > #define cdns_to_intel(_cdns) container_of(_cdns, struct sdw_intel, cdns) > @@ -161,6 +164,115 @@ static int intel_set_bit(void __iomem *base, int offset, u32 value, u32 mask) > return -EAGAIN; > } > > +/* > + * debugfs > + */ > + > +#define RD_BUF (2 * PAGE_SIZE) > + > +static ssize_t intel_sprintf(void __iomem *mem, bool l, > + char *buf, size_t pos, unsigned int reg) > +{ > + int value; > + > + if (l) > + value = intel_readl(mem, reg); > + else > + value = intel_readw(mem, reg); > + > + return scnprintf(buf + pos, RD_BUF - pos, "%4x\t%4x\n", reg, value); > +} > + > +static ssize_t intel_reg_read(struct file *file, char __user *user_buf, > + size_t count, loff_t *ppos) > +{ > + struct sdw_intel *sdw = file->private_data; > + void __iomem *s = sdw->res->shim; > + void __iomem *a = sdw->res->alh; > + char *buf; > + ssize_t ret; > + int i, j; > + unsigned int links, reg; > + > + buf = kzalloc(RD_BUF, GFP_KERNEL); > + if (!buf) > + return -ENOMEM; > + > + links = intel_readl(s, SDW_SHIM_LCAP) & GENMASK(2, 0); > + > + ret = scnprintf(buf, RD_BUF, "Register Value\n"); > + ret += scnprintf(buf + ret, RD_BUF - ret, "\nShim\n"); > + > + for (i = 0; i < 4; i++) { > + reg = SDW_SHIM_LCAP + i * 4; > + ret += intel_sprintf(s, true, buf, ret, reg); > + } > + > + for (i = 0; i < links; i++) { > + ret += scnprintf(buf + ret, RD_BUF - ret, "\nLink%d\n", i); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTLSCAP(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTLS0CM(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTLS1CM(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTLS2CM(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTLS3CM(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_PCMSCAP(i)); > + > + for (j = 0; j < 8; j++) { > + ret += intel_sprintf(s, false, buf, ret, > + SDW_SHIM_PCMSYCHM(i, j)); > + ret += intel_sprintf(s, false, buf, ret, > + SDW_SHIM_PCMSYCHC(i, j)); > + } > + > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_PDMSCAP(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_IOCTL(i)); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_CTMCTL(i)); > + } > + > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_WAKEEN); > + ret += intel_sprintf(s, false, buf, ret, SDW_SHIM_WAKESTS); > + > + ret += scnprintf(buf + ret, RD_BUF - ret, "\nALH\n"); > + for (i = 0; i < 8; i++) > + ret += intel_sprintf(a, true, buf, ret, SDW_ALH_STRMZCFG(i)); > + > + ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); > + kfree(buf); > + > + return ret; > +} > + > +static const struct file_operations intel_reg_fops = { > + .open = simple_open, > + .read = intel_reg_read, > + .llseek = default_llseek, > +}; > + > +static void intel_debugfs_init(struct sdw_intel *sdw) > +{ > + struct dentry *root = sdw_bus_debugfs_get_root(sdw->cdns.bus.debugfs); > + > + if (!root) > + return; > + > + sdw->fs = debugfs_create_dir("intel-sdw", root); > + if (IS_ERR_OR_NULL(sdw->fs)) { Again, you do not care, do not check this. thanks, greg k-h