From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAF2C43219 for ; Sat, 4 May 2019 10:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A0C92085A for ; Sat, 4 May 2019 10:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556965666; bh=QUSfXM9FqxaRXyKBxRPXJoH2PEaZu260LycKAeyGQfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=07YgeVYOMy/GK87ddiz0dXxvw6ejQZVaZ1D8QXzLsb7XTBimQuHF3mtRw20c19VxU 0mTpff39qmVSxriPWUC8HCiuzMo+g//RqhYj218IO57dkCXFtVvz0Y1cba1fUdg4eo IO0qVliZbQ8qhI4If9huxUjPYvYmMhmI14oRFjQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbfEDK1p (ORCPT ); Sat, 4 May 2019 06:27:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:38130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbfEDK1m (ORCPT ); Sat, 4 May 2019 06:27:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB96F20870; Sat, 4 May 2019 10:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556965661; bh=QUSfXM9FqxaRXyKBxRPXJoH2PEaZu260LycKAeyGQfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V19wu9XpFnjFxCsBp9QL2m1SIs7RfxPnSUbx7KSbjJ1giUPK981G6QfeZROc1GX6j aqmsSzbMhwxuhwr0YLtoeVa7eNPpKAv4pwqh5gBu8QqpJKDL5Ho7evVujgbsPeQIRq n14YmmbyuUlmcF+Po8ipGqb/m2FrgPibq3GQVJqg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brian Norris , Claire Chang , "Rafael J. Wysocki" , Kalle Valo Subject: [PATCH 4.19 23/23] ath10k: Drop WARN_ON()s that always trigger during system resume Date: Sat, 4 May 2019 12:25:25 +0200 Message-Id: <20190504102452.278151193@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504102451.512405835@linuxfoundation.org> References: <20190504102451.512405835@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafael J. Wysocki commit 9e80ad37f6788ed52b89a3cfcd593e0aa69b216d upstream. ath10k_mac_vif_chan() always returns an error for the given vif during system-wide resume which reliably triggers two WARN_ON()s in ath10k_bss_info_changed() and they are not particularly useful in that code path, so drop them. Tested: QCA6174 hw3.2 PCI with WLAN.RM.2.0-00180-QCARMSWPZ-1 Tested: QCA6174 hw3.2 SDIO with WLAN.RMH.4.4.1-00007-QCARMSWP-1 Fixes: cd93b83ad927 ("ath10k: support for multicast rate control") Fixes: f279294e9ee2 ("ath10k: add support for configuring management packet rate") Cc: stable@vger.kernel.org Reviewed-by: Brian Norris Tested-by: Brian Norris Tested-by: Claire Chang Signed-off-by: Rafael J. Wysocki Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5622,7 +5622,7 @@ static void ath10k_bss_info_changed(stru } if (changed & BSS_CHANGED_MCAST_RATE && - !WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) { + !ath10k_mac_vif_chan(arvif->vif, &def)) { band = def.chan->band; rateidx = vif->bss_conf.mcast_rate[band] - 1;