* [PATCH] Staging: speakup: Replace return type
@ 2019-05-05 7:26 Madhumitha Prabakaran
2019-05-05 7:32 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Madhumitha Prabakaran @ 2019-05-05 7:26 UTC (permalink / raw)
To: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, speakup, devel,
linux-kernel
Cc: Madhumitha Prabakaran
Replace return type and remove the respective assignment.
Issue found by Coccinelle.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/speakup/i18n.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d36f947..a748eb8052d1 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
input++; /* Advance over %. */
input = skip_flags(input);
input = skip_width(input);
- input = skip_conversion(input);
- return input;
+ return skip_conversion(input);
}
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: speakup: Replace return type
2019-05-05 7:26 [PATCH] Staging: speakup: Replace return type Madhumitha Prabakaran
@ 2019-05-05 7:32 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2019-05-05 7:32 UTC (permalink / raw)
To: Madhumitha Prabakaran
Cc: w.d.hubbs, chris, kirk, gregkh, speakup, devel, linux-kernel
Hello,
Madhumitha Prabakaran, le dim. 05 mai 2019 02:26:45 -0500, a ecrit:
> Replace return type and remove the respective assignment.
I prefer to keep it the way it was, it looks more straightforward for
the reader.
Samuel
> Issue found by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/speakup/i18n.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> input++; /* Advance over %. */
> input = skip_flags(input);
> input = skip_width(input);
> - input = skip_conversion(input);
> - return input;
> + return skip_conversion(input);
> }
>
> /*
> --
> 2.17.1
>
--
Samuel
Progress (n.): The process through which the Internet has evolved from
smart people in front of dumb terminals to dumb people in front of smart
terminals.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-05 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-05 7:26 [PATCH] Staging: speakup: Replace return type Madhumitha Prabakaran
2019-05-05 7:32 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox