From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Angus Ainslie (Purism)" <angus@akkea.ca>,
angus.ainslie@puri.sm,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] usb: typec: tcpm: Clear the fault status register
Date: Mon, 6 May 2019 08:27:36 -0700 [thread overview]
Message-ID: <20190506152736.GA29049@roeck-us.net> (raw)
In-Reply-To: <CAOMZO5C6XQUWBi39jKeVJg3Jj6auB0mF3h8bWMYZ_prXwgc9Fg@mail.gmail.com>
On Mon, May 06, 2019 at 12:11:41PM -0300, Fabio Estevam wrote:
> Hi Angus,
>
> On Mon, May 6, 2019 at 11:10 AM Angus Ainslie (Purism) <angus@akkea.ca> wrote:
> >
> > If the fault status register doesn't get cleared then
> > the ptn5110 interrupt gets stuck on. As the fault register gets
> > set everytime the ptn5110 powers on the interrupt is always stuck.
> >
> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
>
> Since this is a bug fix, I would suggest adding a Fixes tag and Cc
> stable if appropriate.
>
> I would also put this patch as the first one in the series, so that it
> can be easily applied to older stable trees.
Unfortunately there is an added tcpm_log() ... and I am opposed to exporting
that.
Guenter
next prev parent reply other threads:[~2019-05-06 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:08 [PATCH 0/3] usb: typec: tcpm: Add some FAULT_STATUS processing Angus Ainslie (Purism)
2019-05-06 14:08 ` [PATCH 1/3] usb: typec: tcpm: Export the logging function so it can be used by tcpci Angus Ainslie (Purism)
2019-05-06 15:28 ` Guenter Roeck
2019-05-06 14:08 ` [PATCH 2/3] usb: typec: tcpm: Add functions to read the VBUS voltage Angus Ainslie (Purism)
2019-05-06 16:20 ` Guenter Roeck
2019-05-07 12:20 ` Angus Ainslie
2019-05-06 14:08 ` [PATCH 3/3] usb: typec: tcpm: Clear the fault status register Angus Ainslie (Purism)
2019-05-06 15:11 ` Fabio Estevam
2019-05-06 15:27 ` Guenter Roeck [this message]
2019-05-07 11:42 ` Angus Ainslie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506152736.GA29049@roeck-us.net \
--to=linux@roeck-us.net \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox