From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482C8C04A6B for ; Mon, 6 May 2019 19:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13E7020830 for ; Mon, 6 May 2019 19:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557172182; bh=N+qCpPipwaspF17fBy5LbpphIyDHNUlHNnmZs/BQbzQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GsalOZW+9FmIgb3wEtpvPSR4s1ARn2KS/2ZJXqUJAcC5bQ8jQcDPEngamzR2clSZw 3fIhNdzqV9rZGetu8JYoJG4LBsaHG2KrR27Ljkej3gscKv43ZXinDXc1oQ8/gbfwX0 z+jDSPCp+hCy3PTFi2qr9bmnBMeajJrskbqvm5jU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbfEFTtl (ORCPT ); Mon, 6 May 2019 15:49:41 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:45471 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbfEFTtk (ORCPT ); Mon, 6 May 2019 15:49:40 -0400 Received: by mail-wr1-f49.google.com with SMTP id s15so18816597wra.12 for ; Mon, 06 May 2019 12:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=66mlbL0CrJ7/fuI7SCKRUurSoskawyn/TvebHqiOTt8=; b=FlXDTIis0m0j5kLiizL/QvH7mk4IWpAx57X9RljhmJQn1jHHcX2QlV1+UCcX/kOqXy 4jsJbJQANImituAVQ+nE5tOHnBMqPG7ibCwL4IILpy4hTszYW3kr1X2AEBfhJluyssZL mNHUHFxT7GF8O++hCAdk2cYRiMKDPMlh+0Lh65cBhlSqO8y9Jv6gv1eeQYtwQenwSRcc zjzw6zjabhucP+ZT0ZrnbsbIRkAtL/HqH98Egt0TdItAWYknFxwiYBt8YQ15do5I+MKj Q8JRGsl4WNrhvwE/YVnQA75k8ZA9ltrM9IkssX5sbVf9Q6neS/Q2kUww1edOF4kt/eCn 1yvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=66mlbL0CrJ7/fuI7SCKRUurSoskawyn/TvebHqiOTt8=; b=BTWMpTI0zOzSOYQXUNSDhbUSYQuXBFIj2p/J08i7BGxJUqz6vcwZB7i5e+cEV7AQDC jmljIAIvPg8w9QmI18cBCWZGSBHkj+GCYCo3iC3npQmasfmgWul984RhuqR7SG+p8TcW DMNP1R3QRcsMd5eg01sEHpJmRMr7PZztHXLXr545DUblP56qtte5nL0hSLdghaQt0zxw H4F3tZ6FMdXNrYJqQTNbSEVjbBf0VOIJmMC2dop5hgljc9IUCzye6RKwn+/rhdJGo+3u ZHRQpVQ2IfDyqQpprzUqFb2E7inubSf8wKnxwpka/GowpVcTTDWhhDNxPnci0iTuivi3 aouA== X-Gm-Message-State: APjAAAUGBWSu8/yNQwWIzlWLCv2wsIxDjzYzsf0Z7rKZilDWQqVtR2oF xgcv2wxItHAp83zZBQKX0qpyvwZF X-Google-Smtp-Source: APXvYqz01qngGuY0hCwslSWQ48ISnDoheCvFT6fhoee9EhzVYjJ1GRWVZHVliPnRFQd9b70DWVN9Vw== X-Received: by 2002:adf:fe49:: with SMTP id m9mr1443607wrs.73.1557172179285; Mon, 06 May 2019 12:49:39 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id a11sm8221615wmm.35.2019.05.06.12.49.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 12:49:38 -0700 (PDT) Date: Mon, 6 May 2019 21:49:36 +0200 From: Ingo Molnar To: Len Brown Cc: X86 ML , linux-kernel@vger.kernel.org, Kan Liang , Peter Zijlstra , Len Brown , Thomas Gleixner Subject: Re: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package Message-ID: <20190506194936.GA23707@gmail.com> References: <6f53f0e494d743c79e18f6e3a98085711e6ddd0c.1556657368.git.len.brown@intel.com> <20190506114819.GA24079@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Len Brown wrote: > On Mon, May 6, 2019 at 7:48 AM Ingo Molnar wrote: > > > > - unsigned int pkgid = topology_logical_package_id(cpu); > > > + unsigned int pkgid = topology_logical_die_id(cpu); > > > There's many such instances left in this series, please review the whole > > patchset for such problems. > > I agree, the legacy names make the code read as if it were a bug, even > when it is correct. > I'll refresh the series with some re-names to make the end result ready clearly. Thanks a lot! Ingo