From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F41DC004C9 for ; Tue, 7 May 2019 05:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5929320578 for ; Tue, 7 May 2019 05:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207757; bh=h2sorwuKuOV27BsNisrUxV5esCmq3jcbHBZ2tVG+zgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yfCQZAwEjuVF8sxa6yXepDyvuaomkP17P+6j0YhSBKgS0Brl/+OdmSwF1C10SC9Yk nqXeMUSCfL43NuqPr3/hW6S8/i2Rd7Fq202i2f4EGRjI8duEggAjhe4HossolBKJ1U u60FuA87F9hXwkZVxdQJXUS0AV1nZMZjLv1O5DRM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbfEGFmg (ORCPT ); Tue, 7 May 2019 01:42:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:33398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729559AbfEGFm1 (ORCPT ); Tue, 7 May 2019 01:42:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D06F20578; Tue, 7 May 2019 05:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207746; bh=h2sorwuKuOV27BsNisrUxV5esCmq3jcbHBZ2tVG+zgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nZXFN0uUnmedtJ1/OOYDBrY+bSBkpwpVIi9AEZZRojrbaRjYNK4h1gh3Kd3rttgva KNY0bPhB8BG3wVwcYOsyhWc5oUHls3m6S/0nESSYpC84NfTm7MEIuEK6Ba8dYfTvPn 97tsS7yIUcvYgkIeVIQ9KyQuz1mQKHKfggsNw2Hg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Anson Huang , Anson Huang , Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 06/14] Input: snvs_pwrkey - initialize necessary driver data before enabling IRQ Date: Tue, 7 May 2019 01:42:08 -0400 Message-Id: <20190507054218.340-6-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507054218.340-1-sashal@kernel.org> References: <20190507054218.340-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anson Huang [ Upstream commit bf2a7ca39fd3ab47ef71c621a7ee69d1813b1f97 ] SNVS IRQ is requested before necessary driver data initialized, if there is a pending IRQ during driver probe phase, kernel NULL pointer panic will occur in IRQ handler. To avoid such scenario, just initialize necessary driver data before enabling IRQ. This patch is inspired by NXP's internal kernel tree. Fixes: d3dc6e232215 ("input: keyboard: imx: add snvs power key driver") Signed-off-by: Anson Huang Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/snvs_pwrkey.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c index 9adf13a5864a..57143365e945 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -156,6 +156,9 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) return error; } + pdata->input = input; + platform_set_drvdata(pdev, pdata); + error = devm_request_irq(&pdev->dev, pdata->irq, imx_snvs_pwrkey_interrupt, 0, pdev->name, pdev); @@ -172,9 +175,6 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) return error; } - pdata->input = input; - platform_set_drvdata(pdev, pdata); - device_init_wakeup(&pdev->dev, pdata->wakeup); return 0; -- 2.20.1