From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-kernel@vger.kernel.org, stefan.wahren@i2se.com,
devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
phil@raspberrypi.org, Eric Anholt <eric@anholt.net>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"
Date: Tue, 7 May 2019 08:54:05 +0300 [thread overview]
Message-ID: <20190507055405.GI2269@kadam> (raw)
In-Reply-To: <20190506144030.29056-3-nsaenzjulienne@suse.de>
On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote:
> The killable version of wait_for_completion() is meant to be used on
> situations where it should not fail at all costs, but still have the
> convenience of being able to kill it if really necessary. VCHIQ doesn't
> fit this criteria, as it's mainly used as an interface to V4L2 and ALSA
> devices.
>
> Fixes: a772f116702e ("staging: vchiq: switch to wait_for_completion_killable")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> This reverts commit a772f116702e3f0afdd7e6acadc1b8fb3b20b9ff.
> ---
Git just sets you up for failure with its revert. That code was from
when git was really new and now everyone gets annoyed when they see a
raw git hash without a human readable subject. Just say at the start of
the commit message:
This reverts commit a772f116702e ("staging: vchiq: switch to
wait_for_completion_killable").
The killable version of wait_for_completion() is meant to be used on
situations where it should not fail at all costs, but still have the
convenience of being able to kill it if really necessary. VCHIQ doesn't
fit this criteria, as it's mainly used as an interface to V4L2 and ALSA
devices.
Fixes: a772f116702e ("staging: vchiq: switch to wait_for_completion_killable")
regards,
dan carpenter
next prev parent reply other threads:[~2019-05-07 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:40 [PATCH v2 0/3] staging: vchiq: use interruptible waits Nicolas Saenz Julienne
2019-05-06 14:40 ` [PATCH v2 1/3] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" Nicolas Saenz Julienne
2019-05-06 14:40 ` [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable" Nicolas Saenz Julienne
2019-05-06 15:20 ` Dan Carpenter
2019-05-06 15:59 ` Nicolas Saenz Julienne
2019-05-06 16:28 ` Stefan Wahren
2019-05-07 5:54 ` Dan Carpenter [this message]
2019-05-06 14:40 ` [PATCH v2 3/3] staging: vchiq: make wait events interruptible Nicolas Saenz Julienne
2019-05-06 18:12 ` [PATCH v2 0/3] staging: vchiq: use interruptible waits Stefan Wahren
2019-05-06 18:51 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507055405.GI2269@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox