From: Christoph Probst <kernel@probst.it>
To: Steve French <smfrench@gmail.com>
Cc: Pavel Shilovsky <pavel.shilovsky@gmail.com>,
Jeremy Allison <jra@samba.org>, Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cifs: fix strcat buffer overflow in smb21_set_oplock_level()
Date: Tue, 7 May 2019 08:10:28 +0200 [thread overview]
Message-ID: <20190507061028.GP28577@netzpunkt.org> (raw)
In-Reply-To: <CAH2r5ms+RAoe_1c=dUYL=yCs3KWAvqoB00-T4SEpyTjRKiwA6A@mail.gmail.com>
Steve French schrieb am 06.05.2019 um 23:18 Uhr:
> On Mon, May 6, 2019 at 2:03 PM Pavel Shilovsky
> <pavel.shilovsky@gmail.com> wrote:
> >
> > The patch itself is fine but I think we have a bigger problem here:
>
> Good point. Perhaps make update to the same patch to include both changes
I'll update my patch to implement the change suggested by Pavel.
I'll also switch the strcat to strncat and use strncpy in the "None"-case.
Regards,
Christoph
next prev parent reply other threads:[~2019-05-07 6:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 15:16 [PATCH] cifs: fix strcat buffer overflow in smb21_set_oplock_level() Christoph Probst
2019-05-06 16:53 ` Steve French
2019-05-06 16:56 ` Jeremy Allison
2019-05-06 17:02 ` Steve French
2019-05-06 19:03 ` Pavel Shilovsky
2019-05-06 21:18 ` Steve French
2019-05-07 6:10 ` Christoph Probst [this message]
2019-05-07 11:02 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507061028.GP28577@netzpunkt.org \
--to=kernel@probst.it \
--cc=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel.shilovsky@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox