From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD03C004C9 for ; Tue, 7 May 2019 16:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B15F205C9 for ; Tue, 7 May 2019 16:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="eYuS+l8g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfEGQi2 (ORCPT ); Tue, 7 May 2019 12:38:28 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38610 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbfEGQi1 (ORCPT ); Tue, 7 May 2019 12:38:27 -0400 Received: by mail-pl1-f196.google.com with SMTP id a59so8447146pla.5 for ; Tue, 07 May 2019 09:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PrwTuftts3y9+ku/n7DxYc7b66mYzqmoAIBNsj3WhKY=; b=eYuS+l8gX0WHf8bL+hHAPFqQfZhQoR7iHHmMsTJF/AZoxWrP2uPc9hHL65RynHjA5y Ab+bBINOze/EvQMgc+TwH643On5R7KzTcdmED9ud1JFWFO6UK5TocFWfLLIJFhMZ2MUX 7Uxj6u2ycKnfhohWj9D/bkHO7Kzvj7lwGqVUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PrwTuftts3y9+ku/n7DxYc7b66mYzqmoAIBNsj3WhKY=; b=ay/GZapXizPI+5lmsZMu3e5/x4dPOyr3eeufo/HA0KyLumIwC2bteDY7fCp2LJfCFT lNjd/zQ23NQoDg+Ke3t1ZChp94y9cucnF0QoPg7Yj9azNJ+x9BCyIZf3AoJeKGAN4ow2 eW8c62U/t4Hp4O4SwvwZCXg38RjQImhLbRBOuUiQze8VGE0P42p48nHYAw6vnOP1JYDq t7U8fo2Rm/5eOGnvwcl00gGDKJy5P6RjSUKTuo1yGIW7AG6kz+SvPulwJeVTM3uZUhOB WMrwitNh+uzd4LLYYOcW3wVmiqj0EBT5cTOSHFAId0i7PH2M/NCSY/a0GeCxfwDA0b8e b63g== X-Gm-Message-State: APjAAAWqDUL8m9zRSfJ6D50M5w0O+JlgiuSNNm/CybiyAzvhemYbQpMV 9YWfftIqgH91KGSoLyIm0di45A== X-Google-Smtp-Source: APXvYqyXNcsoYomIv94eB9GdJoQ72JRx4fHgYfkhkqw5RgY/K0k80ijGbucCDJQPhA+hQTsNJZh9vw== X-Received: by 2002:a17:902:2847:: with SMTP id e65mr3264147plb.319.1557247107171; Tue, 07 May 2019 09:38:27 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id r8sm18061722pfn.11.2019.05.07.09.38.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 09:38:25 -0700 (PDT) Date: Tue, 7 May 2019 12:38:24 -0400 From: Joel Fernandes To: Steven Rostedt Cc: Greg KH , linux-kernel@vger.kernel.org, Adrian Ratiu , Alexei Starovoitov , Andrew Morton , atishp04@gmail.com, bpf@vger.kernel.org, Brendan Gregg , Brendan Gregg , dancol@google.com, Daniel Borkmann , Dan Williams , dietmar.eggemann@arm.com, duyuchao , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Kees Cook , kernel-team@android.com, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-trace-devel@vger.kernel.org, Manjo Raja Rao , Masahiro Yamada , Masami Hiramatsu , =?utf-8?Q?Micha=C5=82?= Gregorczyk , Michal Gregorczyk , Mohammad Husain , Olof Johansson , qais.yousef@arm.com, rdunlap@infradead.org, Shuah Khan , Srinivas Ramana , Tamir Carmeli , yhs@fb.com Subject: Re: [PATCH v2] kheaders: Move from proc to sysfs Message-ID: <20190507163824.GC89248@google.com> References: <20190504121213.183203-1-joel@joelfernandes.org> <20190504122158.GA23535@kroah.com> <20190504123650.GA229151@google.com> <20190505091030.GA25646@kroah.com> <20190505132623.GA3076@localhost> <20190505163145.45f77e44@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190505163145.45f77e44@oasis.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 05, 2019 at 04:31:45PM -0400, Steven Rostedt wrote: > On Sun, 5 May 2019 13:26:23 +0000 > Joel Fernandes wrote: > > > On Sun, May 05, 2019 at 11:10:30AM +0200, Greg KH wrote: > > > On Sat, May 04, 2019 at 08:36:50AM -0400, Joel Fernandes wrote: > > > > > But, you should change S_IRUGO to the correct octal number, checkpatch > > > > > should have barfed on this change. > > > > > > > > fixed, below is the updated patch inline, thanks! > > > > > > Please resend as a "real" submission, doing so in this format is a bit > > > more difficult to apply. > > > > git am --scissors can do it, but no problem I will send as a formal > > submission. Thanks a lot. > > > > True, but a lot of us depend on scripts to pull in patches from our > INBOX. Which is why we like them to stay with the standard format. Thanks makes sense. So Greg, I submitted this properly, does it look good to you now? Steven, I would appreciate any Acks/Reviews on the patch as well: https://lore.kernel.org/patchwork/patch/1070199/ - Joel