From: Lee Jones <lee.jones@linaro.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: enric.balletbo@collabora.com, bleung@chromium.org,
groeck@chromium.org, jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] iio: cros_ec: Add lid angle driver
Date: Wed, 8 May 2019 11:48:13 +0100 [thread overview]
Message-ID: <20190508104813.GM3995@dell> (raw)
In-Reply-To: <20190425002932.126740-1-gwendal@chromium.org>
On Wed, 24 Apr 2019, Gwendal Grignou wrote:
> Add a IIO driver that reports the angle between the lid and the base for
> ChromeOS convertible device.
>
> Tested on eve with ToT EC firmware.
> Check driver is loaded and lid angle is correct.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes in v6:
> - Fix lock held in an error path error.
>
> Changes in v5:
> - Remove unnecessary define.
> - v4 was the wrong patch file
>
> Changes in v3:
> - Use static channel array, simplify code because index is always 0.
>
> Changes in v2:
> - Fix license, remove driver_module field.
>
> drivers/iio/common/cros_ec_sensors/Kconfig | 9 ++
> drivers/iio/common/cros_ec_sensors/Makefile | 1 +
> .../cros_ec_sensors/cros_ec_lid_angle.c | 139 ++++++++++++++++++
> drivers/mfd/cros_ec_dev.c | 13 +-
Since there aren't any built-time dependencies between them, this
change should be pulled out into a separate patch, which will go in
via the MFD tree.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-05-08 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 0:29 [PATCH v6] iio: cros_ec: Add lid angle driver Gwendal Grignou
2019-04-27 13:21 ` Jonathan Cameron
2019-04-27 13:24 ` Jonathan Cameron
2019-04-27 21:27 ` Gwendal Grignou
2019-05-08 10:48 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508104813.GM3995@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox