From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C74C04A6B for ; Wed, 8 May 2019 11:00:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FE7B20675 for ; Wed, 8 May 2019 11:00:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="N/hUJWD4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbfEHLAB (ORCPT ); Wed, 8 May 2019 07:00:01 -0400 Received: from mail.skyhub.de ([5.9.137.197]:57304 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfEHLAA (ORCPT ); Wed, 8 May 2019 07:00:00 -0400 Received: from zn.tnic (p2E584D41.dip0.t-ipconnect.de [46.88.77.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B4B611EC0C09; Wed, 8 May 2019 12:59:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1557313198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=mRAsdrIOlP+8UoeDEp8dYp3g59kPQNnvrlU59gF02ig=; b=N/hUJWD4cBC3u6Vdz6zVUMuU0LYfQ26fRd2ASJmwCXyYse/iKqthGqMT6rpqoyucQ6VuKF N8k6cd6yJ9K/SgTGdXiGeSElYFInHgAg/G/EGPPN7lUDiqNTEvED/GoCkiOxSU92rxVwig JWWYnBUa97MBmRyFUA5QSfJByyw2IyE= Date: Wed, 8 May 2019 12:57:43 +0200 From: Borislav Petkov To: Greg KH Cc: PanBian , Mauro Carvalho Chehab , James Morse , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: EDAC: Fix memory leak in creating CSROW object Message-ID: <20190508105743.GC19015@zn.tnic> References: <1555554438-103953-1-git-send-email-bianpan2016@163.com> <20190418172548.GL27160@zn.tnic> <20190419003536.GA57795@bianpan2016@163.com> <20190419004516.GC559@zn.tnic> <20190427214925.GE16338@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190427214925.GE16338@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 27, 2019 at 11:49:25PM +0200, Greg KH wrote: > How about this patch, I think it fixes up everything you need to do > here, right? Almost, see the two patches as a reply to this message. I've taken Pan's original patch because it is correct and I doubt you're dying for attribution :-) Then, I productized yours, with some additions. :) Thoughts? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.