From: Lee Jones <lee.jones@linaro.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, rdunlap@infradead.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697
Date: Wed, 8 May 2019 12:36:53 +0100 [thread overview]
Message-ID: <20190508113653.GD31645@dell> (raw)
In-Reply-To: <20190506191614.25051-6-dmurphy@ti.com>
On Mon, 06 May 2019, Dan Murphy wrote:
> The LM3697 is a single function LED driver. The single function LED
> driver needs to reside in the LED directory as a dedicated LED driver
> and not as a MFD device. The device does have common brightness and ramp
> features and those can be accomodated by a TI LMU framework.
>
> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated
> LED dt binding needs to be added. The new LM3697 LED dt binding will then
> reside in the Documentation/devicetree/bindings/leds directory and follow the
> current LED and general bindings guidelines.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v4 - Made assiciated ramp bindings changes and capitalization issue otherwise
> no change - https://lore.kernel.org/patchwork/patch/1068618/
>
> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058762/
> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt -
> https://lore.kernel.org/patchwork/patch/1054501/
>
> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++
> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-08 11:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:16 [PATCH v4 0/7] LMU Rework Dan Murphy
2019-05-06 19:16 ` [PATCH v4 1/7] dt-bindings: mfd: LMU: Fix lm3632 dt binding example Dan Murphy
2019-05-08 11:35 ` Lee Jones
2019-05-06 19:16 ` [PATCH v4 2/7] dt-bindings: mfd: LMU: Add the ramp up/down property Dan Murphy
2019-05-08 11:35 ` Lee Jones
2019-05-06 19:16 ` [PATCH v4 3/7] dt-bindings: mfd: LMU: Add ti,brightness-resolution Dan Murphy
2019-05-08 11:36 ` Lee Jones
2019-05-06 19:16 ` [PATCH v4 4/7] leds: TI LMU: Add common code for TI LMU devices Dan Murphy
2019-05-06 19:16 ` [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2019-05-08 11:36 ` Lee Jones [this message]
2019-05-06 19:16 ` [PATCH v4 6/7] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2019-05-06 19:16 ` [PATCH v4 7/7] leds: lm3697: Introduce the lm3697 driver Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508113653.GD31645@dell \
--to=lee.jones@linaro.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox